Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solution][Resolver] Show origin node details in panel on load (#73313) #73383

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

michaelolo24
Copy link
Contributor

Backports the following commits to 7.x:

…ad (elastic#73313)

* show origin node details in panel on load

* added comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/uptime/rest/telemetry_collectors·ts.apis uptime uptime REST endpoints with generated data telemetry collectors should receive expected results after calling overview logging

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/72852

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:05:10]           └-: uptime
[00:05:10]             └-> "before all" hook
[00:05:10]             └-> "before all" hook
[00:05:15]             └-: uptime REST endpoints
[00:05:15]               └-> "before all" hook
[00:05:15]               └-: with generated data
[00:05:15]                 └-> "before all" hook
[00:05:31]                 └-: telemetry collectors
[00:05:31]                   └-> "before all" hook
[00:05:31]                   └-> "before all" hook: generating data
[00:05:31]                     │ info [uptime/blank] Loading "mappings.json"
[00:05:31]                     │ info [uptime/blank] Loading "data.json"
[00:05:31]                     │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1595894691412916395] [heartbeat-7-generated-test] creating index, cause [api], templates [], shards [1]/[1]
[00:05:31]                     │ info [uptime/blank] Created index "heartbeat-7-generated-test"
[00:05:31]                     │ debg [uptime/blank] "heartbeat-7-generated-test" settings undefined
[00:05:32]                   └-> should receive expected results after calling monitor logging
[00:05:32]                     └-> "before each" hook: global before each
[00:05:32]                     └-> "before each" hook: clear settings
[00:05:32]                       │ debg Deleting saved object [object Object]/%s
[00:05:32]                     └-> "before each" hook: load heartbeat data
[00:05:32]                       │ info [uptime/blank] Loading "mappings.json"
[00:05:32]                       │ info [uptime/blank] Loading "data.json"
[00:05:32]                       │ info [uptime/blank] Skipped restore for existing index "heartbeat-7-generated-test"
[00:05:32]                     └-> "before each" hook
[00:05:32]                     └- ✓ pass  (30ms) "apis uptime uptime REST endpoints with generated data telemetry collectors should receive expected results after calling monitor logging"
[00:05:32]                   └-> should receive expected results after calling overview logging
[00:05:32]                     └-> "before each" hook: global before each
[00:05:32]                     └-> "before each" hook: clear settings
[00:05:32]                       │ debg Deleting saved object [object Object]/%s
[00:05:33]                     └-> "before each" hook: load heartbeat data
[00:05:33]                       │ info [uptime/blank] Loading "mappings.json"
[00:05:33]                       │ info [uptime/blank] Loading "data.json"
[00:05:33]                       │ info [uptime/blank] Skipped restore for existing index "heartbeat-7-generated-test"
[00:05:33]                     └-> "before each" hook
[00:05:33]                     └- ✖ fail: apis uptime uptime REST endpoints with generated data telemetry collectors should receive expected results after calling overview logging
[00:05:33]                     │       Error: expected { overview_page: 1,
[00:05:33]                     │   monitor_page: 0,
[00:05:33]                     │   no_of_unique_monitors: 4,
[00:05:33]                     │   settings_page: 0,
[00:05:33]                     │   monitor_frequency: [ 120, 0.001, 60, 60 ],
[00:05:33]                     │   monitor_name_stats: { min_length: 7, max_length: 22, avg_length: 12 },
[00:05:33]                     │   no_of_unique_observer_locations: 3,
[00:05:33]                     │   observer_location_name_stats: { min_length: 2, max_length: 7, avg_length: 4.8 },
[00:05:33]                     │   dateRangeStart: [ 'now/d' ],
[00:05:33]                     │   dateRangeEnd: [ 'now-30' ],
[00:05:33]                     │   autoRefreshEnabled: true,
[00:05:33]                     │   autorefreshInterval: [ 60 ] } to sort of equal { overview_page: 1,
[00:05:33]                     │   monitor_page: 1,
[00:05:33]                     │   no_of_unique_monitors: 4,
[00:05:33]                     │   settings_page: 0,
[00:05:33]                     │   monitor_frequency: [ 120, 0.001, 60, 60 ],
[00:05:33]                     │   monitor_name_stats: { min_length: 7, max_length: 22, avg_length: 12 },
[00:05:33]                     │   no_of_unique_observer_locations: 3,
[00:05:33]                     │   observer_location_name_stats: { min_length: 2, max_length: 7, avg_length: 4.8 },
[00:05:33]                     │   dateRangeStart: [ 'now/d', 'now/d' ],
[00:05:33]                     │   dateRangeEnd: [ 'now/d', 'now-30' ],
[00:05:33]                     │   autoRefreshEnabled: true,
[00:05:33]                     │   autorefreshInterval: [ 100, 60 ] }
[00:05:33]                     │       + expected - actual
[00:05:33]                     │ 
[00:05:33]                     │        {
[00:05:33]                     │          "autoRefreshEnabled": true
[00:05:33]                     │          "autorefreshInterval": [
[00:05:33]                     │       +    100
[00:05:33]                     │            60
[00:05:33]                     │          ]
[00:05:33]                     │          "dateRangeEnd": [
[00:05:33]                     │       +    "now/d"
[00:05:33]                     │            "now-30"
[00:05:33]                     │          ]
[00:05:33]                     │          "dateRangeStart": [
[00:05:33]                     │            "now/d"
[00:05:33]                     │       +    "now/d"
[00:05:33]                     │          ]
[00:05:33]                     │          "monitor_frequency": [
[00:05:33]                     │            120
[00:05:33]                     │            0.001
[00:05:33]                     │ --
[00:05:33]                     │            "avg_length": 12
[00:05:33]                     │            "max_length": 22
[00:05:33]                     │            "min_length": 7
[00:05:33]                     │          }
[00:05:33]                     │       -  "monitor_page": 0
[00:05:33]                     │       +  "monitor_page": 1
[00:05:33]                     │          "no_of_unique_monitors": 4
[00:05:33]                     │          "no_of_unique_observer_locations": 3
[00:05:33]                     │          "observer_location_name_stats": {
[00:05:33]                     │            "avg_length": 4.8
[00:05:33]                     │       
[00:05:33]                     │       at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
[00:05:33]                     │       at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
[00:05:33]                     │       at Context.it (test/api_integration/apis/uptime/rest/telemetry_collectors.ts:135:25)
[00:05:33]                     │ 
[00:05:33]                     │ 

Stack Trace

{ Error: expected { overview_page: 1,
  monitor_page: 0,
  no_of_unique_monitors: 4,
  settings_page: 0,
  monitor_frequency: [ 120, 0.001, 60, 60 ],
  monitor_name_stats: { min_length: 7, max_length: 22, avg_length: 12 },
  no_of_unique_observer_locations: 3,
  observer_location_name_stats: { min_length: 2, max_length: 7, avg_length: 4.8 },
  dateRangeStart: [ 'now/d' ],
  dateRangeEnd: [ 'now-30' ],
  autoRefreshEnabled: true,
  autorefreshInterval: [ 60 ] } to sort of equal { overview_page: 1,
  monitor_page: 1,
  no_of_unique_monitors: 4,
  settings_page: 0,
  monitor_frequency: [ 120, 0.001, 60, 60 ],
  monitor_name_stats: { min_length: 7, max_length: 22, avg_length: 12 },
  no_of_unique_observer_locations: 3,
  observer_location_name_stats: { min_length: 2, max_length: 7, avg_length: 4.8 },
  dateRangeStart: [ 'now/d', 'now/d' ],
  dateRangeEnd: [ 'now/d', 'now-30' ],
  autoRefreshEnabled: true,
  autorefreshInterval: [ 100, 60 ] }
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.it (test/api_integration/apis/uptime/rest/telemetry_collectors.ts:135:25)
  actual:
   '{\n  "autoRefreshEnabled": true\n  "autorefreshInterval": [\n    60\n  ]\n  "dateRangeEnd": [\n    "now-30"\n  ]\n  "dateRangeStart": [\n    "now/d"\n  ]\n  "monitor_frequency": [\n    120\n    0.001\n    60\n    60\n  ]\n  "monitor_name_stats": {\n    "avg_length": 12\n    "max_length": 22\n    "min_length": 7\n  }\n  "monitor_page": 0\n  "no_of_unique_monitors": 4\n  "no_of_unique_observer_locations": 3\n  "observer_location_name_stats": {\n    "avg_length": 4.8\n    "max_length": 7\n    "min_length": 2\n  }\n  "overview_page": 1\n  "settings_page": 0\n}',
  expected:
   '{\n  "autoRefreshEnabled": true\n  "autorefreshInterval": [\n    100\n    60\n  ]\n  "dateRangeEnd": [\n    "now/d"\n    "now-30"\n  ]\n  "dateRangeStart": [\n    "now/d"\n    "now/d"\n  ]\n  "monitor_frequency": [\n    120\n    0.001\n    60\n    60\n  ]\n  "monitor_name_stats": {\n    "avg_length": 12\n    "max_length": 22\n    "min_length": 7\n  }\n  "monitor_page": 1\n  "no_of_unique_monitors": 4\n  "no_of_unique_observer_locations": 3\n  "observer_location_name_stats": {\n    "avg_length": 4.8\n    "max_length": 7\n    "min_length": 2\n  }\n  "overview_page": 1\n  "settings_page": 0\n}',
  showDiff: true }

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +337.0B 7.3MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@michaelolo24 michaelolo24 merged commit 400e2a9 into elastic:7.x Jul 28, 2020
@michaelolo24 michaelolo24 deleted the backport/7.x/pr-73313 branch July 28, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants