[Security Solution][Resolver] Show origin node details in panel on load #73313

michaelolo24 · 2020-07-27T16:49:40Z

Summary

Show origin process details in panel. The gif below shows an initial load and selecting other process nodes unaffected.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-07-27T16:49:43Z

Pinging @elastic/endpoint-app-team (Feature:Resolver)

elasticmachine · 2020-07-27T16:49:43Z

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

michaelolo24 · 2020-07-27T16:56:44Z

x-pack/plugins/security_solution/public/resolver/view/map.tsx

  useEffectOnce(() => {
    return () => cleanUpQueryParams();
  });

+  useEffect(() => {
+    if (activeDescendantId && crumbId !== activeDescendantId) {


Went this route because, when you refresh the page after selecting a process in the table view (not the timeline view), the old crumbId is still there in the query string even though you don't see a resolver anymore. This just makes sure everything is in sync on load for that view as well as the timeline

can you put that in a comment? We're probably going to schedule rewriting all query string related stuff soon and i want to have all the expected behavior somewhere

yep, done. Thanks!

❔ This only happens when you refresh the page (like you hit f5 or something)? There is that event in panel.tsx called appDetectedNewIdFromQueryParams - I'm assuming that doesn't fire for whatever reason when you refesh? Followup ❔ - should that action fire here as well?

I also want it to show on the initial load of the resolver. The panel should update with the details for the origin node. When I set it up to only work on initial load, I noticed this issue, and decided to set it up to be more general. This is more of an issue of the resolver that's opened in the table (not the timeline) not being preserved through refresh. That could leave you in a state when you open a new resolver that the activeDescendantID is set, but the crumbID isn't set. It doesn't necessarily cause any issues at the moment, but I prefer to be cautious and keep them in sync. In a refactor we should just combine those values in some way since they should always be the same

oatkiller · 2020-07-27T17:33:56Z

x-pack/plugins/security_solution/public/resolver/view/map.tsx

  useEffectOnce(() => {
    return () => cleanUpQueryParams();
  });

+  useEffect(() => {
+    if (activeDescendantId && crumbId !== activeDescendantId) {


can you put that in a comment? We're probably going to schedule rewriting all query string related stuff soon and i want to have all the expected behavior somewhere

bkimmel

1 ❔

michaelolo24 · 2020-07-27T18:47:46Z

@elasticmachine merge upstream

kibanamachine · 2020-07-27T20:49:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: afeeb74

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+337.0B	7.3MB

History

💚 Build #64381 succeeded a6ba12b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ad (elastic#73313) * show origin node details in panel on load * added comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (44 commits) [Search] add server logs (elastic#72454) [SIEM][Timelines] Updates timeline template callout text (elastic#73334) Fix App status flaky test (elastic#72853) [Functional Tests] Increase the timeout when locating the tableview] (elastic#73243) Use "Apply_filter_trigger" in dashboard drilldown (elastic#71468) fix dashboard index pattern race condition (elastic#72899) [Functional Tests] Increase waitTime for timelion to fetch the results (elastic#73255) [Functional Tests] Fix flakiness on TSVB chart on switching index patterns test (elastic#73238) updates cypress to v4.11.0 (elastic#73327) [Metrics UI] Saved views bugs (elastic#72518) [Ingest Manager] Convert select agent config step to use combo box (elastic#73172) Exclude `version` from package config attributes that are copied, add safeguard to package config bulk create (elastic#73128) [Security Solution][ML] Updates siem group name to security (elastic#73218) [Security Solution] Show proper icon for termination status of all processes (elastic#73235) [Security Solution][Resolver] Show origin node details in panel on load (elastic#73313) [Security solution] Threat hunting test coverage improvements (elastic#73276) [Security Solution][Exceptions] - Update exception item comments to include id (elastic#73129) [Enterprise Search] Error state UI tweaks to account for current Cloud SSO behavior (elastic#73324) [dev/build/docker_generator] convert to typescript (elastic#73339) [APM] Fix focus map link on service map (elastic#73338) ...

… on load (#73313) (#73384) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

… on load (#73313) (#73383) * show origin node details in panel on load * added comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

show origin node details in panel on load

a6ba12b

michaelolo24 added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver Feature:Resolver Security Solution Resolver feature v7.9.0 labels Jul 27, 2020

michaelolo24 requested review from a team as code owners July 27, 2020 16:49

michaelolo24 commented Jul 27, 2020

View reviewed changes

oatkiller approved these changes Jul 27, 2020

View reviewed changes

added comment

be64247

michaelolo24 requested a review from kqualters-elastic July 27, 2020 18:22

bkimmel approved these changes Jul 27, 2020

View reviewed changes

Merge branch 'master' into origin-process-panel

afeeb74

kqualters-elastic approved these changes Jul 27, 2020

View reviewed changes

michaelolo24 merged commit ef83e77 into elastic:master Jul 28, 2020

michaelolo24 deleted the origin-process-panel branch July 28, 2020 00:03

michaelolo24 mentioned this pull request Jul 28, 2020

[7.x] [Security Solution][Resolver] Show origin node details in panel on load (#73313) #73383

Merged

michaelolo24 mentioned this pull request Jul 28, 2020

[7.9] [Security Solution][Resolver] Show origin node details in panel on load (#73313) #73384

Merged

michaelolo24 added a commit that referenced this pull request Jul 28, 2020

[7.9] [Security Solution][Resolver] Show origin node details in panel…

88b373f

… on load (#73313) (#73384) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

michaelolo24 mentioned this pull request Aug 3, 2020

[Security Solution][Resolver] Undo origin panel update #73501

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Resolver] Show origin node details in panel on load #73313

[Security Solution][Resolver] Show origin node details in panel on load #73313

michaelolo24 commented Jul 27, 2020 •

edited

Loading

elasticmachine commented Jul 27, 2020

elasticmachine commented Jul 27, 2020

michaelolo24 Jul 27, 2020 •

edited

Loading

oatkiller Jul 27, 2020

michaelolo24 Jul 27, 2020

bkimmel Jul 27, 2020

michaelolo24 Jul 27, 2020

oatkiller Jul 27, 2020

bkimmel left a comment

michaelolo24 commented Jul 27, 2020

kibanamachine commented Jul 27, 2020

[Security Solution][Resolver] Show origin node details in panel on load #73313

[Security Solution][Resolver] Show origin node details in panel on load #73313

Conversation

michaelolo24 commented Jul 27, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jul 27, 2020

elasticmachine commented Jul 27, 2020

michaelolo24 Jul 27, 2020 • edited Loading

Choose a reason for hiding this comment

oatkiller Jul 27, 2020

Choose a reason for hiding this comment

michaelolo24 Jul 27, 2020

Choose a reason for hiding this comment

bkimmel Jul 27, 2020

Choose a reason for hiding this comment

michaelolo24 Jul 27, 2020

Choose a reason for hiding this comment

oatkiller Jul 27, 2020

Choose a reason for hiding this comment

bkimmel left a comment

Choose a reason for hiding this comment

michaelolo24 commented Jul 27, 2020

kibanamachine commented Jul 27, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

michaelolo24 commented Jul 27, 2020 •

edited

Loading

michaelolo24 Jul 27, 2020 •

edited

Loading