KQL support in filter ratio in TSVB #75033

DianaDerevyankina · 2020-08-14T11:31:15Z

Closes #67503

Summary

Enabled KQL support in filter ratio in TSVB

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

Closes elastic#67503

src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/filter_ratios.js

...gins/vis_type_timeseries/server/lib/vis_data/request_processors/series/filter_ratios.test.js

alexwizp

see comments above

src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js

src/plugins/visualizations/server/saved_objects/visualization_migrations.ts

alexwizp

Overall LGTM! Added some nit's

stratoula · 2020-08-21T08:10:31Z

It seems to be cut off

Do we plan to fix this here?

stratoula · 2020-08-21T08:35:41Z

src/plugins/visualizations/server/saved_objects/visualization_migrations.ts

+      // Let it go, the data is invalid and we'll leave it as is
+    }
+    if (visState && visState.type === 'metrics') {
+      const series: any[] = get(visState, 'params.series') || [];


I assume we can't avoid these anys here, right? 😢

If I'm not wrong it's SeriesItemsSchema from src/plugins/vis_type_timeseries/common/types.ts. But not sure that SeriesItemsSchema was a good name for that

Oh... sorry, it's a migration script. I'm ok to see any here cause otherwise we should create a new type for each migration.

sulemanof · 2020-08-21T10:54:47Z

My concern is about additional scrollbar appeared:

I assume this will be resolved by #73250
That means we need to take care of variety of cases the QueryInput component is used and finish up with final solution in #73250. I would ask for help @cchaos

sulemanof · 2020-08-21T10:58:40Z

src/plugins/vis_type_timeseries/common/vis_schema.ts

+    schema.object({
+      language: schema.string(),
+      query: schema.string(),
+    })


There is a queryObject variable to replace

sulemanof · 2020-08-21T11:14:49Z

src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js

-            <EuiFieldText onChange={handleTextChange('numerator')} value={model.numerator} />
+            <QueryBarWrapper
+              query={model.numerator}
+              onChange={(query) => handleQueryChange('numerator', query)}


It is used to wrap callbacks into useCallback to avoid extra re-rendering.

const handleNumeratorQueryChange = useCallback((query) => handleChange({ numerator: query }), [ handleChange, ]);

I know this won't give a lot of effect, since the handleChange is always newly created, but you could also wrap it in useMemo. In such a case we'll make a short step into performance optimization =)

sulemanof

LGTM
Let's resolve the scrollbar issue in #73250

stratoula

LGTM, agree with @sulemanof 🍪

lizozom · 2020-08-23T10:27:58Z

@elasticmachine merge upstream

lizozom · 2020-08-23T12:33:34Z

@elasticmachine merge upstream
@elasticmachine merge upstream

lizozom · 2020-08-26T12:41:08Z

@elasticmachine merge upstream

lizozom · 2020-08-26T13:03:45Z

src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js

  const indexPattern =
    (series.override_index_pattern && series.series_index_pattern) || panel.index_pattern;

  const defaults = {
-    numerator: '*',
-    denominator: '*',
+    numerator: { query: '', language: getDefaultQueryLanguage() },


Is it possible to use data.query.getDefaultQuery() instead?

lizozom

Tested and works.
Added one small request.
Otherwise LGTM

DianaDerevyankina · 2020-08-27T06:47:48Z

@elasticmachine merge upstream

kibanamachine · 2020-08-27T09:48:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 84fe114

Build metrics

async chunks size

id	value	diff	baseline
visTypeTimeseries	1.8MB	+441.0B	1.8MB

History

💔 Build #70774 failed 22a0071
💔 Build #70508 failed 93a533e
💔 Build #70480 failed e85ff76
💚 Build #69885 succeeded a35e0b5
💚 Build #69688 succeeded b682341

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* KQL support in filter ratio in TSVB Closes elastic#67503 * Fix filter_ratio and filter_ratios tests * fix JEST * Refactor some code in filter_ratio, filter_ratios, filter_ratios.test * Edit query value in filter_ratio and filter_ratios.test * Refacor some code in filter_ratio.js and visualization_migrations.ts * Remove duplications in vis_schema and refactor filter_ratio * Refactor filter_ratio.js * Update default query with getDefaultQuery() * Fix filter_ratio and histogram_support tests Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* KQL support in filter ratio in TSVB Closes #67503 * Fix filter_ratio and filter_ratios tests * fix JEST * Refactor some code in filter_ratio, filter_ratios, filter_ratios.test * Edit query value in filter_ratio and filter_ratios.test * Refacor some code in filter_ratio.js and visualization_migrations.ts * Remove duplications in vis_schema and refactor filter_ratio * Refactor filter_ratio.js * Update default query with getDefaultQuery() * Fix filter_ratio and histogram_support tests Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

KQL support in filter ratio in TSVB

33cc09e

Closes elastic#67503

DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 14, 2020

DianaDerevyankina requested a review from alexwizp August 14, 2020 11:31

DianaDerevyankina self-assigned this Aug 14, 2020

DianaDerevyankina and others added 3 commits August 15, 2020 18:46

Merge branch 'DianaDerevyankina' into Diana/67503

e88b697

Fix filter_ratio and filter_ratios tests

f1c790f

fix JEST

ee340b2

alexwizp reviewed Aug 17, 2020

View reviewed changes

src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js Outdated Show resolved Hide resolved

alexwizp reviewed Aug 17, 2020

View reviewed changes

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/filter_ratios.js Outdated Show resolved Hide resolved

alexwizp reviewed Aug 17, 2020

View reviewed changes

...gins/vis_type_timeseries/server/lib/vis_data/request_processors/series/filter_ratios.test.js Outdated Show resolved Hide resolved

alexwizp reviewed Aug 17, 2020

View reviewed changes

DianaDerevyankina added 3 commits August 17, 2020 15:35

Refactor some code in filter_ratio, filter_ratios, filter_ratios.test

cfa58f2

Edit query value in filter_ratio and filter_ratios.test

4715136

Merge branch 'DianaDerevyankina' into Diana/67503

75a9e08

alexwizp requested a review from sulemanof August 20, 2020 14:08

alexwizp reviewed Aug 20, 2020

View reviewed changes

src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js Outdated Show resolved Hide resolved

alexwizp requested a review from stratoula August 20, 2020 14:10

Merge branch 'DianaDerevyankina' into Diana/67503

aba3865

alexwizp reviewed Aug 20, 2020

View reviewed changes

src/plugins/vis_type_timeseries/public/application/components/aggs/filter_ratio.js Outdated Show resolved Hide resolved

alexwizp reviewed Aug 20, 2020

View reviewed changes

src/plugins/visualizations/server/saved_objects/visualization_migrations.ts Outdated Show resolved Hide resolved

alexwizp approved these changes Aug 20, 2020

View reviewed changes

Refacor some code in filter_ratio.js and visualization_migrations.ts

e1024e7

DianaDerevyankina marked this pull request as ready for review August 20, 2020 14:46

DianaDerevyankina requested a review from a team August 20, 2020 14:46

DianaDerevyankina requested a review from a team as a code owner August 20, 2020 14:46

DianaDerevyankina added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Aug 20, 2020

stratoula reviewed Aug 21, 2020

View reviewed changes

sulemanof reviewed Aug 21, 2020

View reviewed changes

DianaDerevyankina added 3 commits August 21, 2020 14:16

Merge branch 'DianaDerevyankina' into Diana/67503

94fc2c2

Remove duplications in vis_schema and refactor filter_ratio

60081d8

Refactor filter_ratio.js

b682341

sulemanof approved these changes Aug 21, 2020

View reviewed changes

stratoula approved these changes Aug 21, 2020

View reviewed changes

stratoula mentioned this pull request Aug 21, 2020

KQL autocomplete cut off in visualize editor with styled-components #75557

Merged

7 tasks

Merge branch 'master' into Diana/67503

a35e0b5

Merge branch 'master' into Diana/67503

e85ff76

lizozom reviewed Aug 26, 2020

View reviewed changes

lizozom approved these changes Aug 26, 2020

View reviewed changes

Update default query with getDefaultQuery()

93a533e

elasticmachine and others added 2 commits August 27, 2020 00:47

Merge branch 'master' into Diana/67503

22a0071

Fix filter_ratio and histogram_support tests

84fe114

DianaDerevyankina merged commit 8e2cb56 into elastic:master Aug 27, 2020

DianaDerevyankina mentioned this pull request Aug 27, 2020

[7.x] KQL support in filter ratio in TSVB (#75033) #76071

Merged

wylieconlon added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Jan 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KQL support in filter ratio in TSVB #75033

KQL support in filter ratio in TSVB #75033

DianaDerevyankina commented Aug 14, 2020

alexwizp left a comment

alexwizp left a comment

stratoula commented Aug 21, 2020

stratoula Aug 21, 2020 •

edited

Loading

alexwizp Aug 21, 2020

alexwizp Aug 21, 2020

sulemanof commented Aug 21, 2020

sulemanof Aug 21, 2020

sulemanof Aug 21, 2020

sulemanof left a comment

stratoula left a comment

lizozom commented Aug 23, 2020

lizozom commented Aug 23, 2020

lizozom commented Aug 26, 2020

lizozom Aug 26, 2020

lizozom left a comment

DianaDerevyankina commented Aug 27, 2020

kibanamachine commented Aug 27, 2020

KQL support in filter ratio in TSVB #75033

KQL support in filter ratio in TSVB #75033

Conversation

DianaDerevyankina commented Aug 14, 2020

Summary

Checklist

For maintainers

alexwizp left a comment

Choose a reason for hiding this comment

alexwizp left a comment

Choose a reason for hiding this comment

stratoula commented Aug 21, 2020

stratoula Aug 21, 2020 • edited Loading

Choose a reason for hiding this comment

alexwizp Aug 21, 2020

Choose a reason for hiding this comment

alexwizp Aug 21, 2020

Choose a reason for hiding this comment

sulemanof commented Aug 21, 2020

sulemanof Aug 21, 2020

Choose a reason for hiding this comment

sulemanof Aug 21, 2020

Choose a reason for hiding this comment

sulemanof left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

lizozom commented Aug 23, 2020

lizozom commented Aug 23, 2020

lizozom commented Aug 26, 2020

lizozom Aug 26, 2020

Choose a reason for hiding this comment

lizozom left a comment

Choose a reason for hiding this comment

DianaDerevyankina commented Aug 27, 2020

kibanamachine commented Aug 27, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

stratoula Aug 21, 2020 •

edited

Loading