Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index pattern edit field formatter API #78352

Merged
merged 25 commits into from
Oct 20, 2020

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Sep 23, 2020

Summary

Adds methods for setting field formatters - indexPattern.setFieldFormat, indexPattern.deleteFieldFormat

Also adds indexPattern.getFormatterForFieldNoDefault - used by management interface.

FieldFormatter instances aren't created until they're retrieved, instead of being created when the IndexPattern instance is initiated.

Checklist

Delete any items that are not applicable to this PR.

Dev Docs

Adds methods for setting field formatters - indexPattern.setFieldFormat, indexPattern.deleteFieldFormat Also adds indexPattern.getFormatterForFieldNoDefault - used by management interface.

@mattkime mattkime changed the title Index pattern edit field formatter Index pattern edit field formatter API Sep 23, 2020
@mattkime mattkime mentioned this pull request Sep 24, 2020
63 tasks
@elastic elastic deleted a comment from kibanamachine Oct 7, 2020
@mattkime mattkime marked this pull request as ready for review October 7, 2020 19:03
@mattkime mattkime requested a review from a team as a code owner October 7, 2020 19:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 v8.0.0 v7.11.0 release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Oct 7, 2020
@mattkime mattkime linked an issue Oct 7, 2020 that may be closed by this pull request
7 tasks
@mattkime mattkime requested a review from ppisljar October 7, 2020 19:07
@mattkime
Copy link
Contributor Author

mattkime commented Oct 7, 2020

Split off field_mapping refactor changes into its own PR - #79918 - this PR will be a bit simpler once thats merged to master.

@mattkime
Copy link
Contributor Author

mattkime commented Oct 8, 2020

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@mattkime
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
indexPatternManagement 208 206 -2

async chunks size

id before after diff
indexPatternManagement 662.1KB 662.3KB +164.0B

page load bundle size

id before after diff
data 1.1MB 1.1MB -1.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@mattkime mattkime merged commit c8e40d5 into elastic:master Oct 20, 2020
mattkime added a commit to mattkime/kibana that referenced this pull request Oct 20, 2020
* Index pattern edit field formatter API
# Conflicts:
#	docs/development/plugins/data/public/kibana-plugin-plugins-data-public.indexpattern.md
#	docs/development/plugins/data/server/kibana-plugin-plugins-data-server.indexpattern.md
#	src/plugins/data/server/server.api.md
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 20, 2020
* master: (64 commits)
  Rename Security Solution Bug Template (elastic#81187)
  Update links (elastic#81125)
  Specify format for date range query (elastic#81025)
  [Alerting] Improve toast when alert is created (elastic#80327)
  [UX] Add empty states (elastic#80904)
  Add TS config for kibana_legacy (elastic#80992)
  [Telemetry] Add method to enable endpoint security data usage example (elastic#80940)
  [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794)
  Fix reactRouterNavigate when used with a string (elastic#80520)
  [Security Solution] [Detections] Read privileges for dependencies (elastic#80852)
  [ML] Fixing exclude frequent in advanced wizard (elastic#81121)
  Fix security solution template label (elastic#80976)
  [DOCS] Update index management docs (elastic#80893)
  [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814)
  skip flaky suite (elastic#81072)
  [Task Manager] Cleans up legacy plugin structure (elastic#80381)
  Support unsigned_long fields (elastic#81115)
  [Form lib] Export internal state instead of raw state (elastic#80842)
  [Lens] Add toast notification when visualization is saved (elastic#80788)
  Index pattern edit field formatter API (elastic#78352)
  ...
mattkime added a commit that referenced this pull request Oct 20, 2020
@sulemanof sulemanof mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index Pattern API - clean up field index pattern and index patterns interfaces
4 participants