[Alerting] Improve toast when alert is created #80327
Conversation
There was a problem hiding this comment.
I'd agree the toast should indicate an alert is being created. Looks like there is also a button with a "Save" label on that form - should we change that to "Create"? The error message on creation in that form is "Cannot create alert", which seems like it's already create-centered ...
Also wondering if we should add the name back to the message - at some point someone thought there was value in doing that.
Generally, defer to @gchaps for things like this tho ...
x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.tsx
Outdated
Show resolved
Hide resolved
Yeah, that's what I noticed too. This seems to indicate that it's always about creating (a new) alert: |
|
Ya, there's a separate path for "update", which uses "Save" in it's messaging, which seems fine ... perhaps there was some copy-pasta between these, or something |
x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
force-pushed
the
improve-alert-toast
branch
from
5f5eb3a to
0d391c5
Compare
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
|
@pmuellr Okay to merge? |
pmuellr
added
Feature:Alerting
Team:ResponseOps
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
added
v8.0.0
release_note:skip
|
@sqren ya, go ahead and merge. For alerting PRs, we usually require two reviews, except for super simple PRs - and I think this is one :-) |
* master: (64 commits) Rename Security Solution Bug Template (elastic#81187) Update links (elastic#81125) Specify format for date range query (elastic#81025) [Alerting] Improve toast when alert is created (elastic#80327) [UX] Add empty states (elastic#80904) Add TS config for kibana_legacy (elastic#80992) [Telemetry] Add method to enable endpoint security data usage example (elastic#80940) [Alerting] Add scoped cluster client to alerts and actions services (elastic#80794) Fix reactRouterNavigate when used with a string (elastic#80520) [Security Solution] [Detections] Read privileges for dependencies (elastic#80852) [ML] Fixing exclude frequent in advanced wizard (elastic#81121) Fix security solution template label (elastic#80976) [DOCS] Update index management docs (elastic#80893) [APM] Error rate on service list page is not in sync with the value at the transaction page (elastic#80814) skip flaky suite (elastic#81072) [Task Manager] Cleans up legacy plugin structure (elastic#80381) Support unsigned_long fields (elastic#81115) [Form lib] Export internal state instead of raw state (elastic#80842) [Lens] Add toast notification when visualization is saved (elastic#80788) Index pattern edit field formatter API (elastic#78352) ...
Closes #80142
The current toast is not very informative. It doesn't mention that an alert was created and I was genuinely confused whether I had created an alert, or something else (I was testing permissions and was seeing some odd behaviour with actions and having a better toast message would have helped me understand what was going on).
Before
