-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mappings editor] Fix bug when switching between mapping tabs #78707
Merged
alisonelizabeth
merged 3 commits into
elastic:master
from
alisonelizabeth:bugfix/mappings_editor/dyanmic_templates_error
Oct 1, 2020
Merged
[Mappings editor] Fix bug when switching between mapping tabs #78707
alisonelizabeth
merged 3 commits into
elastic:master
from
alisonelizabeth:bugfix/mappings_editor/dyanmic_templates_error
Oct 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
Feature:Index Management
Index and index templates UI
v8.0.0
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Feature:Mappings Editor
Index mappings editor UI
v7.10.0
labels
Sep 29, 2020
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
sebelga
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing this and adding the test 👍
alisonelizabeth
deleted the
bugfix/mappings_editor/dyanmic_templates_error
branch
October 1, 2020 12:43
alisonelizabeth
added a commit
that referenced
this pull request
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Index Management
Index and index templates UI
Feature:Mappings Editor
Index mappings editor UI
release_note:fix
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78705
Possibly a regression of #71065.
Release note
This change fixes a bug in the index template wizard, which resulted in an incorrect validation error when a user toggles between the dynamic templates and advanced settings tabs without providing any values.