Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mappings editor] Fix bug when switching between mapping tabs #78707

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,33 @@ describe('Mappings editor: core', () => {
isNumericDetectionVisible = exists('advancedConfiguration.numericDetection');
expect(isNumericDetectionVisible).toBe(false);
});

test('should keep default dynamic templates value when switching tabs', async () => {
await act(async () => {
testBed = setup({
value: { ...defaultMappings, dynamic_templates: [] }, // by default, the UI will provide an empty array for dynamic templates
onChange: onChangeHandler,
});
});
testBed.component.update();

const {
actions: { selectTab, getJsonEditorValue },
} = testBed;

// Navigate to dynamic templates tab and verify empty array
await selectTab('templates');
let templatesValue = getJsonEditorValue('dynamicTemplatesEditor');
expect(templatesValue).toEqual([]);

// Navigate to advanced tab
await selectTab('advanced');

// Navigate back to dynamic templates tab and verify empty array persists
await selectTab('templates');
templatesValue = getJsonEditorValue('dynamicTemplatesEditor');
expect(templatesValue).toEqual([]);
});
});

describe('component props', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,10 @@ const formSerializer: SerializerFunc<MappingsTemplates | undefined> = (formData)
// Silently swallow errors
}

return Array.isArray(parsedTemplates) && parsedTemplates.length > 0
? {
dynamic_templates: parsedTemplates,
}
: undefined;
return {
dynamic_templates:
Array.isArray(parsedTemplates) && parsedTemplates.length > 0 ? parsedTemplates : [],
};
};

const formDeserializer = (formData: { [key: string]: any }) => {
Expand Down