[Drilldowns][Docs] Communicate the visualization types that support drilldowns #78761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
docs
Feature:Drilldowns
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
gchaps
reviewed
Sep 29, 2020
| @@ -40,6 +40,12 @@ For a comparison of the Elastic subscription levels, | |||
| see https://www.elastic.co/subscriptions[the subscription page]. | |||
| ============================================== | |||
|
|
|||
| [NOTE] | |||
There was a problem hiding this comment.
Is this note necessary as the individual pages have a list of supported panels?
There was a problem hiding this comment.
I removed the note.
I thought it make sense to emphasise that not all panels support drilldown and then that support is different per panel type. But I guess this is indeed redundant.
There was a problem hiding this comment.
My bigger concern was that there were back-to-back notes, which can be difficult to read. Another option is to put the text about panel support above the note that starts with "Some action types" . But don't use Note format for the panel support text.
There was a problem hiding this comment.
I see. I am good with removing! Thanks for feedback
streamich
approved these changes
Sep 30, 2020
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Oct 1, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 1, 2020
* master: (36 commits) [I18n] fix eui tokens (elastic#78951) Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768) Make the actual Vislib import async (elastic#78949) Fix ML conditionals links Cypress tests (elastic#78568) [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761) [UX] Improve page-load axis (elastic#78392) [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610) Data plugin README (elastic#78750) [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009) fixing api test (elastic#78964) [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129) [Loggers] Rename "telemetry" to "usage" (elastic#78130) [Usage Collection] [schema] `ui_metric` (elastic#78827) [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772) [Discover] Unskip doc link functional test (elastic#78600) [ML] Functional tests - stabilize calendar edit tests (elastic#78950) [UX] Improve page responsive (elastic#78759) [QA][Code Coverage] Team Assignment Docs Update (elastic#78890) [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra (elastic#78209) [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855) ...
Dosant
added a commit
that referenced
this pull request
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #74787
Preview
Note: support is different per drilldown type (depends on underlying trigger support).
That's why I added a list to each sub-page.
Checklist
For maintainers