Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize calendar edit tests #78950

Merged
merged 3 commits into from
Oct 1, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Sep 30, 2020

Summary

This PR stabilizes the calendar edit test by making sure the correct calendar form is displayed on the edit page.

Also adds a validation of the calendar id in the edit test and a few minor fixes (test step name, suite tag, test subj to check for the event modal).

Closes #78288

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 30, 2020
@pheyos pheyos requested a review from a team as a code owner September 30, 2020 13:22
@pheyos pheyos self-assigned this Sep 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Member Author

pheyos commented Sep 30, 2020

Checking test stability in a flaky test runner job ... no calendar related failure in 50 runs (for the few permission test failures, see #78965).

@pheyos
Copy link
Member Author

pheyos commented Sep 30, 2020

@elasticmachine merge upstream

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
ml 10.5MB +196.0B 10.5MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 42b5d78 into elastic:master Oct 1, 2020
@pheyos pheyos deleted the stabilize_calendar_edit_test branch October 1, 2020 05:46
pheyos added a commit to pheyos/kibana that referenced this pull request Oct 1, 2020
This PR stabilizes the calendar edit test by making sure the correct calendar form is displayed on the edit page.
pheyos added a commit that referenced this pull request Oct 1, 2020
This PR stabilizes the calendar edit test by making sure the correct calendar form is displayed on the edit page.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 1, 2020
* master: (36 commits)
  [I18n] fix eui tokens (elastic#78951)
  Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768)
  Make the actual Vislib import async (elastic#78949)
  Fix ML conditionals links Cypress tests (elastic#78568)
  [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761)
  [UX] Improve page-load axis (elastic#78392)
  [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610)
  Data plugin README (elastic#78750)
  [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009)
  fixing api test (elastic#78964)
  [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129)
  [Loggers] Rename "telemetry" to "usage" (elastic#78130)
  [Usage Collection] [schema] `ui_metric` (elastic#78827)
  [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772)
  [Discover] Unskip doc link functional test (elastic#78600)
  [ML] Functional tests - stabilize calendar edit tests (elastic#78950)
  [UX] Improve page responsive  (elastic#78759)
  [QA][Code Coverage] Team Assignment Docs Update (elastic#78890)
  [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra  (elastic#78209)
  [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.10.0 v8.0.0
Projects
None yet
5 participants