Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting UI] Updating 'Add new' wording #80509

Merged
merged 4 commits into from
Oct 16, 2020
Merged

[Alerting UI] Updating 'Add new' wording #80509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6257b45
Updating 'Add new' wording
ymao1 Oct 14, 2020
3df7f49
PR fixes
ymao1 Oct 15, 2020
ec06d7d
i18n_check fix
ymao1 Oct 15, 2020
0dc143a
Merge branch 'master' into alerting/add-new
kibanamachine Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...riggers_actions_ui/public/application/sections/action_connector_form/action_form.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ describe('action_form', () => {
`);
});

it('does not render "Add new" button for preconfigured only action type', async () => {
it('does not render "Add new connector" button for preconfigured only action type', async () => {
ymao1 marked this conversation as resolved.
Show resolved Hide resolved
await setup();
const actionOption = wrapper.find('[data-test-subj="preconfigured-ActionTypeSelectOption"]');
actionOption.first().simulate('click');
Expand Down
2 changes: 1 addition & 1 deletion ...ins/triggers_actions_ui/public/application/sections/action_connector_form/action_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ export const ActionForm = ({
}}
>
<FormattedMessage
defaultMessage="Add new"
defaultMessage="Add new connector"
ymao1 marked this conversation as resolved.
Show resolved Hide resolved
id="xpack.triggersActionsUI.sections.alertForm.addNewConnectorEmptyButton"
/>
</EuiButtonEmpty>
Expand Down