Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] describe steps for resolving limit overages #81716

Merged
merged 3 commits into from
Nov 2, 2020
Merged

[docs] describe steps for resolving limit overages #81716

merged 3 commits into from
Nov 2, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 27, 2020 •
edited
Loading

Fixes #81555

Extends the CI Metrics docs to include a section on diagnosing limit overages, understanding what causes them, when to request a limit increase, and how to validate the limits locally if desired.

Preview: https://kibana_81716.docs-preview.app.elstc.co/guide/en/kibana/master/ci-metrics.html

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 labels Oct 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger requested a review from mattkime October 27, 2020 02:27
@spalger spalger requested a review from mshustov October 27, 2020 17:32
@mistic mistic mentioned this pull request Oct 30, 2020
Merged
mattkime
mattkime approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spalger !

jbudz
jbudz approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to accept a page bundle size that failed the check? I see the reach out to operations part, so LGTM, but was curious if there's a workflow that allows a large diff to go in.

edit: ah, I see in the top comment now to request a limit increase

@spalger spalger merged commit 6451a8f into elastic:master Nov 2, 2020
@spalger spalger deleted the docs/resolving-bundle-size-overages branch November 2, 2020 15:32
This was referenced Nov 2, 2020
Merged
Merged
spalger added a commit to spalger/kibana that referenced this pull request Nov 2, 2020
@spalger
[docs] describe steps for resolving limit overages (elastic#81716)
9a47801 
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit to spalger/kibana that referenced this pull request Nov 2, 2020
@spalger
[docs] describe steps for resolving limit overages (elastic#81716)
3dae84f 
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit that referenced this pull request Nov 2, 2020
@spalger
[7.x] [docs] describe steps for resolving limit overages (#81716) (#8…
c98e285 
…2302)

Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit that referenced this pull request Nov 2, 2020
@spalger
[7.10] [docs] describe steps for resolving limit overages (#81716) (#…
d185cef 
…82303)

Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: spalger <spalger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

@jbudz jbudz jbudz approved these changes

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kibana CI Metrics check should provide info to fix failure
5 participants
@spalger @elasticmachine @mattkime @jbudz @mshustov