Add a link to documentation in the alerts and actions management UI #81909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
|
Placement is good. @gchaps may correct me, but I think we can just say 'Documentation' in this instance. |
|
Wow, quick review, thanks! I also wanted to note I copied how it was done in Snapshot and Restore page but happy to rename it do "Documentation" as well I also wanted to note it points to the user guide (https://www.elastic.co/guide/en/kibana/7.9/managing-alerts-and-actions.html) and not the general documentation that includes getting started and such. This may change before the 7.11 release anyway but let me know if that should change it in the meantime. |
|
I see what @mdefazio is saying--it feels like a lot of repetition. So I lean toward "Documentation". |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Oct 30, 2020
…lastic#81909) * Add a link to documentation in the alerts and actions management UI * Update label * Remove usage of any on registries # Conflicts: # x-pack/plugins/triggers_actions_ui/public/application/context/alerts_context.tsx
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 30, 2020
* master: (71 commits) [Chrome] Extension to append an element to the last breadcrumb (elastic#82015) [Monitoring] Thread pool rejections alert (elastic#79433) [Actions] Fix actionType type on registerType function (elastic#82125) [Security Solution] Modal for saving timeline (elastic#81802) add tests for index pattern switching (elastic#81987) TS project references for share plugin (elastic#82051) [Graph] Fix problem with duplicate ids (elastic#82109) skip 'returns a single bucket if array has 1'. related elastic#81460 Add a link to documentation in the alerts and actions management UI (elastic#81909) [Fleet] fix duplicate ingest pipeline refs (elastic#82078) Context menu trigger for URL Drilldown (elastic#81158) SO management: fix legacy import index pattern selection being reset when switching page (elastic#81621) Fixed dead links (elastic#78696) [Search] Add "restore" to session service (elastic#81924) fix Lens heading structure (elastic#81752) [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (elastic#82011) Remove legacy app arch items from codeowners. (elastic#82084) [TSVB] Renamed 'positive rate' to 'counter rate' (elastic#80939) Expressions/migrations2 (elastic#81281) [Telemetry] [Schema] remove number type and support all es number types (elastic#81774) ...
mikecote
added
release_note:enhancement
and removed
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #75548
In this PR, I'm adding a link to the user guides in the alerts and actions management page. See top right of screenshot below.
I am also removing the casting to
anyfor the alert and action type registries as I'm writing my unit tests. Mostly of that extra work is in this commit: 86c4205.