[ML] Data Frame Analytics: Fix feature importance cell value and decision path chart #82011

walterra · 2020-10-29T14:09:47Z

Summary

Fixes a regression introduced in #81123. The regression caused data grid cells for feature importance to be empty and clicking on the button to show the decision path chart popover to render the whole page empty.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately

…ure.

elasticmachine · 2020-10-29T14:09:50Z

Pinging @elastic/ml-ui (:ml)

peteharverson · 2020-10-29T14:23:53Z

The results for this config causes the page to crash. I think it must be because there are no feature importance results (job has a low training percent). Uses the iris data set:

{
  "id": "iris_classification",
  "create_time": 1603981165099,
  "version": "8.0.0",
  "description": "10 percent training",
  "source": {
    "index": [
      "iris"
    ],
    "query": {
      "match_all": {}
    }
  },
  "dest": {
    "index": "iris_classification",
    "results_field": "ml"
  },
  "analysis": {
    "classification": {
      "dependent_variable": "class",
      "num_top_feature_importance_values": 4,
      "class_assignment_objective": "maximize_minimum_recall",
      "num_top_classes": -1,
      "prediction_field_name": "class_prediction",
      "training_percent": 10,
      "randomize_seed": -8472867106198368000
    }
  },
  "analyzed_fields": {
    "includes": [
      "class",
      "petal_length",
      "petal_width",
      "sepal_length",
      "sepal_width"
    ],
    "excludes": []
  },
  "model_memory_limit": "2mb",
  "allow_lazy_start": false,
  "max_num_threads": 1
}

Update - confirmed this is fixed by 96ccaef

peteharverson · 2020-10-29T14:26:37Z

x-pack/plugins/ml/public/application/components/data_grid/common.ts

+
+  return featureNames.map((fName, index) => {
+    const offset = featureNames.length * index;
+    const featureClassNames = classNames.slice(offset, offset + featureNames.length);


This is causing the page to crash with regression jobs:

I think this is because the expected shape coming from regression job is different compared to result from classification job here.

Confirmed this is fixed by 96ccaef

qn895 · 2020-10-29T14:31:57Z

Ran into an issue where if the class name is a boolean, the feature importance will not show up.

…portance-2

alvarezmelissa87

Gave this a test and LGTM (once the booelan issue is addressed) ⚡

walterra · 2020-10-29T23:26:07Z

@qn895 I fixed the decision path chart for boolean type classification classes, please have another look.

qn895 · 2020-10-29T23:32:04Z

Tested and LGTM 🎉

kibanamachine · 2020-10-30T01:07:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 653c846

Metrics [docs]

async chunks size

id	before	after	diff
`ml`	6.6MB	6.6MB	+2.4KB

History

💔 Build #84628 failed e5a77b9
💚 Build #84541 succeeded 31239b6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peteharverson

Tested latest edits and LGTM

…sion path chart (elastic#82011) Fixes a regression that caused data grid cells for feature importance to be empty and clicking on the button to show the decision path chart popover to render the whole page empty.

…sion path chart (#82011) (#82107) Fixes a regression that caused data grid cells for feature importance to be empty and clicking on the button to show the decision path chart popover to render the whole page empty.

…sion path chart (#82011) (#82108) Fixes a regression that caused data grid cells for feature importance to be empty and clicking on the button to show the decision path chart popover to render the whole page empty.

* master: (71 commits) [Chrome] Extension to append an element to the last breadcrumb (elastic#82015) [Monitoring] Thread pool rejections alert (elastic#79433) [Actions] Fix actionType type on registerType function (elastic#82125) [Security Solution] Modal for saving timeline (elastic#81802) add tests for index pattern switching (elastic#81987) TS project references for share plugin (elastic#82051) [Graph] Fix problem with duplicate ids (elastic#82109) skip 'returns a single bucket if array has 1'. related elastic#81460 Add a link to documentation in the alerts and actions management UI (elastic#81909) [Fleet] fix duplicate ingest pipeline refs (elastic#82078) Context menu trigger for URL Drilldown (elastic#81158) SO management: fix legacy import index pattern selection being reset when switching page (elastic#81621) Fixed dead links (elastic#78696) [Search] Add "restore" to session service (elastic#81924) fix Lens heading structure (elastic#81752) [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (elastic#82011) Remove legacy app arch items from codeowners. (elastic#82084) [TSVB] Renamed 'positive rate' to 'counter rate' (elastic#80939) Expressions/migrations2 (elastic#81281) [Telemetry] [Schema] remove number type and support all es number types (elastic#81774) ...

walterra added 2 commits October 29, 2020 12:20

[ML] Adds helpers to transform flattened fields back to object struct…

4266638

…ure.

[ML] Fix cell value.

31239b6

walterra added regression :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.10.0 v7.11.0 labels Oct 29, 2020

walterra requested review from alvarezmelissa87, peteharverson and qn895 October 29, 2020 14:09

walterra requested a review from a team as a code owner October 29, 2020 14:09

walterra self-assigned this Oct 29, 2020

peteharverson reviewed Oct 29, 2020

View reviewed changes

walterra added 3 commits October 29, 2020 15:46

[ML] Fix helper functions.

edc8e2f

[ML] Fix classification feature importance object.

96ccaef

Merge remote-tracking branch 'upstream/master' into ml-fix-feature-im…

e5a77b9

…portance-2

alvarezmelissa87 approved these changes Oct 29, 2020

View reviewed changes

walterra added 2 commits October 29, 2020 23:28

[ML] Fix types.

358bb67

[ML] Fix decision path chart for boolean types.

653c846

qn895 approved these changes Oct 29, 2020

View reviewed changes

peteharverson approved these changes Oct 30, 2020

View reviewed changes

walterra added the bug Fixes for quality problems that affect the customer experience label Oct 30, 2020

walterra merged commit b0a223e into elastic:master Oct 30, 2020

walterra deleted the ml-fix-feature-importance-2 branch October 30, 2020 09:40

walterra mentioned this pull request Oct 30, 2020

[7.x] [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (#82011) #82107

Merged

walterra mentioned this pull request Oct 30, 2020

[7.10] [ML] Data Frame Analytics: Fix feature importance cell value and decision path chart (#82011) #82108

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Data Frame Analytics: Fix feature importance cell value and decision path chart #82011

[ML] Data Frame Analytics: Fix feature importance cell value and decision path chart #82011

walterra commented Oct 29, 2020

elasticmachine commented Oct 29, 2020

peteharverson commented Oct 29, 2020 •

edited

Loading

peteharverson Oct 29, 2020

qn895 Oct 29, 2020

peteharverson Oct 29, 2020

qn895 commented Oct 29, 2020

alvarezmelissa87 left a comment

walterra commented Oct 29, 2020

qn895 commented Oct 29, 2020

kibanamachine commented Oct 30, 2020

peteharverson left a comment

[ML] Data Frame Analytics: Fix feature importance cell value and decision path chart #82011

[ML] Data Frame Analytics: Fix feature importance cell value and decision path chart #82011

Conversation

walterra commented Oct 29, 2020

Summary

Checklist

elasticmachine commented Oct 29, 2020

peteharverson commented Oct 29, 2020 • edited Loading

peteharverson Oct 29, 2020

Choose a reason for hiding this comment

qn895 Oct 29, 2020

Choose a reason for hiding this comment

peteharverson Oct 29, 2020

Choose a reason for hiding this comment

qn895 commented Oct 29, 2020

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

walterra commented Oct 29, 2020

qn895 commented Oct 29, 2020

kibanamachine commented Oct 30, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

History

peteharverson left a comment

Choose a reason for hiding this comment

peteharverson commented Oct 29, 2020 •

edited

Loading