[Alerting UI] Fix console error when setting connector params

x-pack/plugins/actions/server/builtin_action_types/pagerduty.test.ts

@@ -140,6 +140,40 @@ describe('validateParams()', () => {
     expect(validateParams(actionType, params)).toEqual(params);
   });
 
+  test('should validate and pass when params is valid and optional timestamp is empty string', () => {
+    expect(validateParams(actionType, {})).toEqual({});
+
+    const params = {
+      eventAction: 'trigger',
+      dedupKey: 'a dedupKey',
+      summary: 'a summary',
+      source: 'a source',
+      severity: 'critical',
+      timestamp: '',
+      component: 'a component',
+      group: 'a group',
+      class: 'a class',
+    };
+    expect(validateParams(actionType, params)).toEqual(params);
+  });
+
+  test('should validate and pass when params is valid and optional timestamp is null', () => {
+    expect(validateParams(actionType, {})).toEqual({});
+
+    const params = {
+      eventAction: 'trigger',
+      dedupKey: 'a dedupKey',
+      summary: 'a summary',
+      source: 'a source',
+      severity: 'critical',
+      timestamp: null,
+      component: 'a component',
+      group: 'a group',
+      class: 'a class',
+    };
+    expect(validateParams(actionType, params)).toEqual(params);
+  });
+
   test('should validate and throw error when params is invalid', () => {
     expect(() => {
       validateParams(actionType, { eventAction: 'ackynollage' });

x-pack/plugins/actions/server/builtin_action_types/pagerduty.ts

@@ -86,7 +86,7 @@ const ParamsSchema = schema.object(
 
 function validateParams(paramsObject: unknown): string | void {
   const { timestamp, eventAction, dedupKey } = paramsObject as ActionParamsType;
-  if (timestamp != null) {
+  if (timestamp != null && timestamp.length > 0) {
     try {
       const date = Date.parse(timestamp);
       if (isNaN(date)) {

x-pack/plugins/triggers_actions_ui/public/application/components/text_area_with_message_variables.tsx

@@ -63,7 +63,7 @@ export const TextAreaWithMessageVariables: React.FunctionComponent<Props> = ({
         fullWidth
         isInvalid={errors && errors.length > 0 && inputTargetValue !== undefined}
         name={paramsProperty}
-        value={inputTargetValue}
+        value={inputTargetValue || ''}
         data-test-subj={`${paramsProperty}TextArea`}
         onChange={(e: React.ChangeEvent<HTMLTextAreaElement>) => onChangeWithMessageVariable(e)}
         onFocus={(e: React.FocusEvent<HTMLTextAreaElement>) => {

x-pack/plugins/triggers_actions_ui/public/application/components/text_field_with_message_variables.tsx

@@ -50,7 +50,7 @@ export const TextFieldWithMessageVariables: React.FunctionComponent<Props> = ({
       id={`${paramsProperty}Id`}
       isInvalid={errors && errors.length > 0 && inputTargetValue !== undefined}
       data-test-subj={`${paramsProperty}Input`}
-      value={inputTargetValue}
+      value={inputTargetValue || ''}
       onChange={(e: React.ChangeEvent<HTMLInputElement>) => onChangeWithMessageVariable(e)}
       onFocus={(e: React.FocusEvent<HTMLInputElement>) => {
         setCurrentTextElement(e.target);

x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/connector_add_flyout.tsx

@@ -72,10 +72,8 @@ export const ConnectorAddFlyout = ({
   const [isSaving, setIsSaving] = useState<boolean>(false);
 
   const closeFlyout = useCallback(() => {
-    setActionType(undefined);
-    setConnector(initialConnector);
     onClose();
-  }, [onClose, initialConnector]);
+  }, [onClose]);
 
   const canSave = hasSaveActionsCapability(capabilities);