Ensure table updates when page settings update #8422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire table should also refresh when one of the options changes. Otherwise, the rows are not filled in correctly to the bottom of the page.
|
LGTM2 |
cjcenizal
reviewed
Sep 22, 2016
| * Recreate the entire table when: | ||
| * - the underlying data changes (esResponse) | ||
| * - one of the view options changes (vis.params) | ||
| */ |
This was referenced Sep 22, 2016
elastic-jasper
added a commit
that referenced
this pull request
Sep 22, 2016
--------- **Commit 1:** Ensure table updates when page settings update The entire table should also refresh when one of the options changes. Otherwise, the rows are not filled in correctly to the bottom of the page. * Original sha: 0cf2202 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-09-21T23:38:29Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 22, 2016
--------- **Commit 1:** Ensure table updates when page settings update The entire table should also refresh when one of the options changes. Otherwise, the rows are not filled in correctly to the bottom of the page. * Original sha: 0cf2202 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-09-21T23:38:29Z
thomasneirynck
added a commit
that referenced
this pull request
Sep 22, 2016
[backport] PR #8422 to 5.x
thomasneirynck
added a commit
that referenced
this pull request
Sep 22, 2016
[backport] PR #8422 to 5.0
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Ensure table updates when page settings update The entire table should also refresh when one of the options changes. Otherwise, the rows are not filled in correctly to the bottom of the page. * Original sha: 37ff2d61b5913cf242d5b4ac0a539954ba2c56f9 [formerly 0cf2202] * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-09-21T23:38:29Z Former-commit-id: 8823761
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8422 to 5.x Former-commit-id: 292894d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8322.
Table visualizations now correctly fill out all the rows, when changing any of the paging options