[Discover] Change default sort handling #85561
Conversation
| @@ -32,6 +31,6 @@ export function getDefaultSort( | |||
| if (indexPattern.timeFieldName && isSortable(indexPattern.timeFieldName, indexPattern)) { | |||
| return [[indexPattern.timeFieldName, defaultSortOrder]]; | |||
| } else { | |||
| return [['_score', defaultSortOrder]]; | |||
There was a problem hiding this comment.
quick question @timroes , I don't think it makes much sense to sort by _score by default when it's an index pattern without timefield. this function now returna an empty default sorting, which would mean, that ES get's the info sort by _doc. I think that's a better choice here, would you agree?
There was a problem hiding this comment.
@timroes update: changed the default to _score for index patterns without time field (so it is handled like before and nothing breaks)
…-10-discover-default-sort
kertal
added
release_note:enhancement
v7.11.0
v8.0.0
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
…om:kertal/kibana into kertal-pr-2020-12-10-discover-default-sort
|
@elasticmachine merge upstream |
…-10-discover-default-sort
…om:kertal/kibana into kertal-pr-2020-12-10-discover-default-sort
…-10-discover-default-sort
| @@ -26,12 +25,12 @@ import { SortOrder } from '../components/table_header/helpers'; | |||
| * the default sort is returned depending of the index pattern | |||
| */ | |||
| export function getDefaultSort( | |||
| indexPattern: IndexPattern, | |||
| indexPattern: IndexPattern | undefined, | |||
There was a problem hiding this comment.
In what scenario would index pattern be undefined?
There was a problem hiding this comment.
It shouldn't. But when using this function in an embeddable, according the TypeScript it could be. So the decision was the edit in the function or in the embeddable. decided to modify here, since the function would work without an index pattern.
…-10-discover-default-sort
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
* master: (48 commits) Fix request with disabled aggregation (elastic#85696) [Security Solution][Detections][Threshold Rules] Threshold Rule Bug Fixes (elastic#84918) Removed a possibility to define two different names for Alert types on API and UI level. (elastic#86236) Bump Node.js from version 14.15.2 to 14.15.3 (elastic#86593) [index patterns] Fleep app - Keep saved object field list until field caps provides fields (elastic#85370) [Security Solutions] fix timeline tabs + layout (elastic#86581) Upgrade to hapi version 20 (elastic#85406) App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (elastic#82791) Rename chartLibrary setting to legacyChartsLibrary (elastic#86529) [CI] TeamCity updates (elastic#85843) [Maps] Use Json for mvt-tests (elastic#86492) [Rollup Jobs] Added autofocus to cron editor (elastic#86324) [Monitoring][Alerting] CCR read exceptions alert (elastic#85908) [CI] Bump memory for main CI workers (elastic#86541) Explicitly set Elasticsearch heap size during CI and local development (elastic#86513) [App Search] Updates to results on the documents view (elastic#86181) [Discover] Change default sort handling (elastic#85561) [App Search] Convert DocumentCreationModal to DocumentCreationFlyout (elastic#86508) [App Search] Sample Engines should have access to the Crawler (elastic#86502) Fixed duplication of create new modal (elastic#86489) ...
Summary
This PR changes the way default sorting is handled in Discover. It was not possible to remove sorting. With the introduction of EuiDataGrid in #67259 this will mandatory, the user can't reset sorting with the legacy behavior (nothing happens, no explanation why). Also it makes sense to allow the user the get a unsorted view.
Before:
When there's no sorting given in state, the index patterns default sorting is used (index pattern with time field: by
indexPattern.timeFieldName, index pattern without time field: by_score) when sending the request to ES.After:
With this PR, the default sorting is pre-selected in state, so it's removable. In case sort in state is empty, sorting by
_docis used for index pattern with timefield, and_scorefor index pattern without timefield.Testing
There is no way to unsort in UI until #67259, but you could edit the saved search saved object, setting
sortto '[]'. Checking if it's sorted correctly in Discover and the saved search embeddable.Checklist