Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix request with disabled aggregation #85696

Merged
merged 7 commits into from
Dec 21, 2020
Merged

Fix request with disabled aggregation #85696

merged 7 commits into from
Dec 21, 2020

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Dec 11, 2020 •
edited
Loading

Summary

Fixes #81263

Issue: the disabled Terms agg with the otherBucket param enabled produces an error

error

Fix: skip the postFlightRequest call if the agg is disabled.

For maintainers

@sulemanof sulemanof requested a review from lukeelmers December 11, 2020 12:01
@sulemanof sulemanof marked this pull request as ready for review December 11, 2020 12:02
@sulemanof sulemanof requested a review from a team as a code owner December 11, 2020 12:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@sulemanof
Copy link
Contributor Author

pinging @lukeelmers

lukeelmers
lukeelmers approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sulemanof! @elastic/kibana-app-services is anybody able to take a look to give this an official codeowners approval?

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47142 47902 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 1003.1KB 1003.1KB +13.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit f67f1ec into elastic:master Dec 21, 2020
@sulemanof sulemanof deleted the fix/disabled_agg_error branch December 21, 2020 10:42
@sulemanof sulemanof mentioned this pull request Dec 21, 2020
Merged
sulemanof pushed a commit to sulemanof/kibana that referenced this pull request Dec 21, 2020
@kibanamachine @sulemanof
Fix request with disabled aggregation (elastic#85696)
a755cdf 
* Fix request with disabled aggregation

* Update unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@sulemanof sulemanof mentioned this pull request Dec 21, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 21, 2020
@gmmorris
Merge branch 'master' into alerts/remove-generics-defaults-redux
561ebb1 
* master: (48 commits)
  Fix request with disabled aggregation (elastic#85696)
  [Security Solution][Detections][Threshold Rules] Threshold Rule Bug Fixes (elastic#84918)
  Removed a possibility to define two different names for Alert types on API and UI level. (elastic#86236)
  Bump Node.js from version 14.15.2 to 14.15.3 (elastic#86593)
  [index patterns] Fleep app - Keep saved object field list until field caps provides fields (elastic#85370)
  [Security Solutions] fix timeline tabs + layout (elastic#86581)
  Upgrade to hapi version 20 (elastic#85406)
  App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. (elastic#82791)
  Rename chartLibrary setting to legacyChartsLibrary (elastic#86529)
  [CI] TeamCity updates (elastic#85843)
  [Maps] Use Json for mvt-tests (elastic#86492)
  [Rollup Jobs] Added autofocus to cron editor (elastic#86324)
  [Monitoring][Alerting] CCR read exceptions alert (elastic#85908)
  [CI] Bump memory for main CI workers (elastic#86541)
  Explicitly set Elasticsearch heap size during CI and local development (elastic#86513)
  [App Search] Updates to results on the documents view (elastic#86181)
  [Discover] Change default sort handling  (elastic#85561)
  [App Search] Convert DocumentCreationModal to DocumentCreationFlyout (elastic#86508)
  [App Search] Sample Engines should have access to the Crawler (elastic#86502)
  Fixed duplication of create new modal (elastic#86489)
  ...
sulemanof pushed a commit that referenced this pull request Dec 21, 2020
@kibanamachine
Fix request with disabled aggregation (#85696) (#86626)
8f5aa00 
* Fix request with disabled aggregation

* Update unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
sulemanof pushed a commit that referenced this pull request Dec 21, 2020
@kibanamachine
Fix request with disabled aggregation (#85696) (#86627)
e1af4e4 
* Fix request with disabled aggregation

* Update unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@mattkime mattkime mattkime approved these changes

Assignees
No one assigned
Labels
release_note:fix v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@sulemanof @elasticmachine @kibanamachine @mattkime @lukeelmers