[APM] Adds "Logs" tab to transaction details for related trace logs #85859
Conversation
… related trace logs.
|
Pinging @elastic/apm-ui (Team:apm) |
| <LogStream | ||
| startTimestamp={startTimestamp - framePaddingMs} | ||
| endTimestamp={endTimestamp + framePaddingMs} | ||
| query={`trace.id:"${transaction.trace.id}" OR "${transaction.trace.id}"`} |
There was a problem hiding this comment.
This matches the filter for the "Trace logs" link in the action menu: https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections.ts#L183, but i'm not sure why this needs to be an OR, is it just me or is this redundant?
There was a problem hiding this comment.
My guess is that is will pick up entries that don't have the trace.id attribute set but contain the trace id in other fields, but first matching with the field name gives exact matches.
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
To update your PR or re-run it, just comment with: |
| @@ -46,9 +33,10 @@ export function TransactionTabs({ | |||
| exceedsMax, | |||
| }: Props) { | |||
| const history = useHistory(); | |||
| const tabs = [timelineTab, metadataTab]; | |||
| const tabs = [timelineTab, metadataTab, logsTab]; | |||
There was a problem hiding this comment.
nit: might want to define this outside the component to indicate that it is static.
There was a problem hiding this comment.
Nvm, I see a green build. Feel free to merge.
… related trace logs. (elastic#85859)
|
Just for awareness, #85148 introduced the ability to customize the rendering of the field contents. 😉 |
* master: (66 commits) [Alerting] fixes broken Alerting Example plugin (elastic#85774) [APM] Service overview instances table (elastic#85770) [Security Solution] Unskip timeline creation Cypress test (elastic#85871) properly recognize enterprise licenses (elastic#85849) [SecuritySolution][Detections] Adds SavedObject persistence to Signals Migrations (elastic#85690) [TSVB] Fix functional tests flakiness and unskip them (elastic#85388) [Fleet] Change permissions for Fleet enroll role (elastic#85802) Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (elastic#84768) [Security Solution][Detections] Add alert source to detection rule action context (elastic#85488) [Discover] Don't display hide/show button for histogram when there's no time filter (elastic#85424) skip flaky suite (elastic#78553) License checks for alerts plugin (elastic#85649) skip flaky suite (elastic#84992) skip 'query return results valid for scripted field' elastic#78553 Allow action types to perform their own mustache variable escaping in parameter templates (elastic#83919) [ML] More machine learning links in doc_links_service.ts (elastic#85365) Removed Alerting & Event Log deprecated fields that should not be using (elastic#85652) Closes elastic#79995 by adding new tab in transaction details to show related trace logs. (elastic#85859) Fix outdated jest snapshot [Maps] Surface on prem EMS (elastic#85729) ...
|
Tests ok. |
cauemarcondes
added
the
apm:test-plan-done
Closes #79995 by adding new tab in transaction details to show related trace logs.