[APM] Increase Logstream height #85913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increasing the component height for more optimal viewing experience.
formgeist
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Dec 15, 2020
| @@ -135,6 +135,7 @@ function LogsTabContent({ transaction }: { transaction: Transaction }) { | |||
| startTimestamp={startTimestamp - framePaddingMs} | |||
| endTimestamp={endTimestamp + framePaddingMs} | |||
| query={`trace.id:"${transaction.trace.id}" OR "${transaction.trace.id}"`} | |||
| height={640} | |||
There was a problem hiding this comment.
Any reason for that specific size? Is it relative to other containers or does that number just work well?
There was a problem hiding this comment.
400 is too slim for space we typically have in this panel, and it's divisible by 8 😊 Do you think it's too tall?
There was a problem hiding this comment.
No it's fine. Just curious. Feel free to merge when green.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increasing the component height from
400pxto640pxfor more optimal viewing experience.Before
After
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)This was checked for cross-browser compatibilityFor maintainers
This was checked for breaking API changes and was labeled appropriately