Fix config validation when elastic.apm is defined
#96502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
33 tasks
pgayvallet
commented
Apr 7, 2021
| @@ -9,22 +9,27 @@ | |||
| import { ConfigService } from '@kbn/config'; | |||
| import { CriticalError } from '../errors'; | |||
|
|
|||
| const ignoredPaths = ['dev.', 'elastic.apm.']; | |||
There was a problem hiding this comment.
The dev schema was only added to avoid validation failures. Now that we have this ignore list instead, I removed the dev schema and added it here.
Comment on lines
+14
to
+15
| const invalidConfigExitCode = 78; | ||
| const legacyInvalidConfigExitCode = 64; |
There was a problem hiding this comment.
Keeping 64 for invalid config keys until 8.0 for BWC. Added a task to change that in the 8.0 meta issue.
|
Pinging @elastic/kibana-core (Team:Core) |
mshustov
reviewed
Apr 8, 2021
There was a problem hiding this comment.
tested locally:
for the legacy config:
logging.verbose: 42received
FATAL Error: [config validation of [logging].verbose]: expected value of type [boolean] but got [number]
error Command failed with exit code 1.
with
server.basePath: 1received:
FATAL CLI ERROR Error: [config validation of [server].basePath]: expected value of type [string] but got [number]
|
@mshustov you tested using the dev mode, right? If so, the main process is not 'forwarding' the return code from the kibana server. For |
mshustov
approved these changes
Apr 8, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Apr 9, 2021
pgayvallet
added a commit
that referenced
this pull request
Apr 9, 2021
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Apr 12, 2021
…to-metrics-tab * 'master' of github.com:elastic/kibana: (44 commits) [Exploratory View]Additional metrics for kpi over time (elastic#96532) [Fleet] UI changes on hosted policy detail view (elastic#96337) Stacked line charts incorrectly shows one term as 100% (elastic#96203) [Fleet] Create enrollment API keys as current user (elastic#96464) [Lens] Make table and metric show on top Chart switcher (elastic#96601) skip flaky suite (elastic#96691) [Lens] Hide "Show more errors" once expanded (elastic#96605) [Discover] Unskip histogram hiding test (elastic#95759) skip flyout test, add linked issue elastic#96708 skip copy_to_space_flyout_internal.test.tsx elastic#96708 fix config validation (elastic#96502) Document telemetry fields for stack security features (elastic#96638) [Partial Results] Move inspector adapter integration into search source (elastic#96241) [RAC] Rule registry plugin (elastic#95903) [APM] Run precommit tasks sequentially (elastic#96551) [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (elastic#96633) [Security Solution] [Cases] Small UI bugfixes (elastic#96511) [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (elastic#96363) App Search: Result Component Updates (elastic#96184) [Alerting] Preconfigured alert history index connector (elastic#94909) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #96376
Fix a regression caused by the removal of the legacy server's schema in #95510
elastic.apmprefix when checking for unused keysdevconfig and use the same mechanism to ignore unuseddev.*keys78error code when the configuration validation failsChecklist