[Upgrade Assistant] Support Kibana deprecations #97159

alisonelizabeth · 2021-04-14T17:20:26Z

This PR adds support for displaying Kibana deprecations in Upgrade Assistant.

UA is consuming the core deprecations service in order to surface these deprecations. Each deprecation should either have manual steps that we display in the UI to fix the deprecation or an API to automatically resolve it. It is possible to have both, although I'm not sure how common this will be.

There are a few limitations of the deprecations service that we are currently looking into:

The service only requires a deprecation message and no details field like the ES deprecation info API. UA derives the deprecation title as: "<domainId> is using a deprecated feature" (needs copy review) and the message field is used as the description.
We are not yet enforcing config deprecations to provide corrective steps ([Core deprecations service] Require manual corrective steps for config deprecations #96059)
Ability to sort by config vs. other Kibana deprecations in the deprecation list ([Core deprecations service] Add deprecationType field #96060)
Some deprecations don't have an associated domainId, so it renders as an empty string in the UI (core team looking into)
For corrective steps, the service only requires a plugin owner to register an array of strings. It would be ideal to support both a title/description, as well as allow markdown for the description.
We may consider bulk actions support, but this work is not yet being tracked.

How to review

Local setup

Edit constants.ts and change UA_READONLY_MODE to false to enable UA.
There are no Kibana plugins that are registering an API action to resolve a deprecation yet. I have mocked this behavior for testing purposes in 480b6cd. This is specific to the timelion plugin. (This commit has been reverted so you will need to pull it into your branch to test.)
To trigger the timelion deprecation, go to app/timelion, click Save at the top of the page, then Save entire Timelion sheet. When you go back to UA, the deprecation should appear in the list.
To trigger a config deprecation, you can disable the spaces plugin in your kibana.yml: xpack.spaces.enabled: false

Summary of changes

The overview page now shows the Kibana deprecation stats in addition to Elasticsearch
A new Kibana deprecations page, which lists all Kibana deprecations. Users can search, or filter by critical level. Depending on the deprecation, a user can also view steps to fix the deprecation or click a button to automatically resolve it.
I extracted some common components for the ES and Kibana deprecation list view - search bar, filter actions, empty prompt, pagination.
Updated a11y tests and CITs
Added telemetry support for navigating to Kibana deprecations page

Screenshots

…bana_deprecations

cjcenizal

Awesome work Alison! I had a lot of very superficial comments and nit-picks. Nothing blocking. Tested locally and everything looks good. Here are a few UX comments.

Deprecations summary

When the counts are 0, can we style them in light gray, or maybe just replace it with a green check icon and the word "None" in gray? Dmitry will probably have a much better idea. The goal is to improve scannability and also to remove the cognitive dissonance of a red 0 which looks bad, but is actually good.

Is there any way to make the entire panel clickable, like EuiCard? Making people acquire this little link introduces a tiny bit of friction, and I think we really want to grease the rails so people can get into these deprecations and start fixing them as smoothly as possible.

Empty prompt copy

I think the language here is potentially misleading. "Ready to upgrade!" makes it sound like I'm ready to upgrade, but I might still need to address issues in the other tab. Can we do a copy pass to guide users to the appropriate next step?

Markdown support

I might have already mentioned it, so at the risk of sounding like a 🦜 I'll say markdown would let us format code blocks and links really nicely. Maybe we can make an issue to track this with Core?

Deprecation toggle feedback

Can we get a writer to take a pass at this? I'd expect to see these imperative statements as button labels, not as state change confirmations. I'm more used to seeing something like "Elasticsearch deprecations will be logged" and "Elasticsearch deprecations won't be logged".

Steps modal vs flyout

I think a flyout will give us more real estate to show the user a long list of steps. We can also provide more identifiable information in the header, like the "Critical" badge and whatever else is being surfaced in the table row. We can also surface the "Quick resolve" button in the footer. WDYT?

Resolution UX

Before I click "Resolve" I'd like to know what the outcome will be. To be honest I don't really know what happened even after clicking the button. A better UX would be modal content that sets my expectations appropriately (e.g. "Your 5 timelion sheets will be converted into dashboards. You will be able to find them in the Dashboards app, with the prefix 'Converted-timelion' in their name.") and success toast content that confirms those expectations have been met (e.g. "5 timelion sheets converted to dashboards. Find them in the Dashboards app. [Link]).

cjcenizal · 2021-04-27T18:39:17Z

x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json

-              "type": "long"
+              "type": "long",
+              "_meta": {
+                "description": "Number of times a user opened the Elasticsearch cluster deprecations page"


Minor nit: this is technically a tab, not a page. Might be more future-proof to generically say "a user viewed the list of Elasticsearch cluster deprecations." Same idea with the index deprecations, below.

cjcenizal · 2021-04-27T18:51:39Z

.../upgrade_assistant/public/application/components/es_deprecations/deprecation_tab_content.tsx

@@ -28,6 +34,61 @@ export interface CheckupTabProps extends UpgradeAssistantTabProps {
  checkupLabel: string;
 }

+export const filterDeps = (level: LevelFilterOption, search: string = '') => {


Small nit, I've seen a shift from enums to unions, usually in src/core. Applied here, LevelFilterOption would become:

type LevelFilterOption = 'all' | 'critical';

Then conditions like line 40 becomes a bit terser:

if (level !== 'all') {

I used to be a big fan of enums but have drifted toward unions over time. I don't feel strongly either way though so happy to leave this as-is. Just wanted to share an alternative. :)

👍 This was existing behavior. I've changed it to a union. There are several other places in the code where enums are still being used, but I think this can be addressed on a case-by-case basis.

cjcenizal · 2021-04-27T19:00:11Z

.../upgrade_assistant/public/application/components/es_deprecations/deprecation_tab_content.tsx

@@ -28,6 +34,61 @@ export interface CheckupTabProps extends UpgradeAssistantTabProps {
  checkupLabel: string;
 }

+export const filterDeps = (level: LevelFilterOption, search: string = '') => {


Nit: This name sounds like function is responsible for filtering the dependencies. But it's really for creating a filtering function. How about naming it createDependenciesFilter?

cjcenizal · 2021-04-27T19:05:07Z

.../upgrade_assistant/public/application/components/es_deprecations/deprecation_tab_content.tsx

+  if (search.length > 0) {
+    conditions.push((dep) => {
+      try {
+        const searchReg = new RegExp(search, 'i');


Are we only searching if a string includes another string, or is there more to this search? If the former, then dep.message.toLowerCase().includes(search.toLowerCase()) seems easier to read and understand to me. Not sure if everyone knows what 'i' means in this context. But this is like.... the nittiest nitpick ever so I'm also fine leaving this as-is. 😄

That is true includes might be slightly easier to read. Converting both strings toLowerCase makes me feel uneasy thats all :d

I'd be surprised if we have devs not familiar with basic regular expressions writing code in our code base!

I'm impartial on what you decide on. Just sharing my thoughts

Thank you both for your feedback! I've decided to leave as-is, but left a brief code comment for anyone who might be unsure what i is used for.

cjcenizal · 2021-04-27T21:06:42Z

.../upgrade_assistant/public/application/components/es_deprecations/deprecation_tab_content.tsx

+/**
+ * Collection of calculated fields based on props
+ */
+const calcFields = {


I think this design adds some unnecessary complexity in a few ways:

Attaching the helper functions to the calcFields namespace object introduces more information but I'm not seeing any benefits -- maybe I'm overlooking them?

The helper functions are named like nouns, not verbs, which seems unusual. Was this deliberate?

The functions expect a props config object. Yet at their call-sites we're destructuring the component's props and then re-assembling them into objects to provide as arguments, to satisfy this expectation. Seems like unnecessary work.

I'd suggest simplifying these by removing the namespacing object, naming the functions with verbs, and refactoring the parameters to accept individual arguments, for example:

const filterDeprecations = (currentFilter: LevelFilterOption, search: string, deprecations?: EnrichedDeprecationInfo[] = []) => deprecations.filter(filterDeps(currentFilter, search));

👍 This was pre-existing code. Agreed this can be simplified and made more clear. I've updated the implementation.

cjcenizal · 2021-04-27T21:33:28Z

.../upgrade_assistant/public/application/components/kibana_deprecations/kibana_deprecations.tsx

+
+  const toggleResolveModal = (newResolveModalContent?: DomainDeprecationDetails) => {
+    if (typeof newResolveModalContent === 'undefined') {
+      setResolveModalContent(undefined);


Similar question here.

cjcenizal · 2021-04-27T21:34:58Z

.../upgrade_assistant/public/application/components/kibana_deprecations/kibana_deprecations.tsx

+
+    notifications.toasts.addSuccess(i18nTexts.successMessage);
+    // Refetch deprecations
+    await getAllDeprecations();


Is this await necessary?

cjcenizal · 2021-04-27T21:42:52Z

x-pack/plugins/upgrade_assistant/public/application/components/shared/search_bar/search_bar.tsx

+        <EuiFlexItem>
+          <EuiFlexGroup>
+            <EuiFlexItem grow={false}>
+              <EuiFieldSearch


Did you consider using EuiSearchBar? I haven't looked into whether it will work in this use case, so I'm just mentioning it for awareness.

Thanks for pointing this out! I had not. This implementation was mostly carried over from the previous UI. I will make a note to look into this and consider updating in a follow-up PR.

cjcenizal · 2021-04-27T21:43:18Z

x-pack/plugins/upgrade_assistant/public/application/components/types.ts

@@ -35,7 +35,6 @@ export enum LoadingState {
 export enum LevelFilterOption {
  all = 'all',
  critical = 'critical',
-  warning = 'warning',


Does the API no longer support this level?

warning is still relevant, but not applicable for the filter

cjcenizal · 2021-04-27T21:46:26Z

x-pack/plugins/upgrade_assistant/tests_client_integration/kibana.test.ts

+ * 2.0.
+ */
+
+import type { DomainDeprecationDetails } from 'kibana/public';


I love seeing all these tests! I didn't notice them at first because they're in tests_client_integration and I'm used to seeing them inside a root-level __jest__ directory. What was the intention behind using a different directory name? It might be easier for people to discover them if we follow the __jest__ convention.

I think this decision is somewhat related to #87599 (review). I don't think it's suggested to have a root-level __jest__ directory anymore.

Thanks Alison! I traced that issue you linked to back to #85513, where it looks like the intent was to move tests out of __tests__ directories. Have you heard something regarding the use of __jest__ directories? Just trying to understand the decision and background.

Ah, good catch! I might have confused the two. Let me follow up with the operations team to confirm. The directory name wasn't made as part of this PR so I think it's OK to address separately if needed.

Perhaps this is worth discussing at our next team sync (I'll add it to the agenda). Core's recommendation is to put jest tests alongside source files, with the exception of jest "integration tests", which should live in a folder called integration_tests and run via node scripts/jest_integration. However, this is intended for any jest tests that use an external service (ES/Kibana) as part of the tests.

alisonelizabeth · 2021-04-28T01:34:35Z

Thanks for the review and great feedback, @cjcenizal! I'm still working through some of your code comments and will respond to each one when I've addressed it.

In regards to your UX comments:

When the counts are 0, can we style them in light gray, or maybe just replace it with a green check icon and the word "None" in gray? Dmitry will probably have a much better idea. The goal is to improve scannability and also to remove the cognitive dissonance of a red 0 which looks bad, but is actually good.

This is a great point. I'll work with @dborodyansky on improving this. I will likely address this in a separate PR since this one did not specifically introduce the concept of stats panels.

Is there any way to make the entire panel clickable, like EuiCard? Making people acquire this little link introduces a tiny bit of friction, and I think we really want to grease the rails so people can get into these deprecations and start fixing them as smoothly as possible.

I like this idea! I had not considered that. Agreed it's not ideal for the user to have to click the View deprecations link as-is. Similar to my comment above, I'd like to address this separately.

I think the language here is potentially misleading. "Ready to upgrade!" makes it sound like I'm ready to upgrade, but I might still need to address issues in the other tab. Can we do a copy pass to guide users to the appropriate next step?

👍 Deb will be reviewing the copy.

I might have already mentioned it, so at the risk of sounding like a 🦜 I'll say markdown would let us format code blocks and links really nicely. Maybe we can make an issue to track this with Core?

👍 This is on core's radar. A similar request has come up for another new service they're working on and are exploring ideas (notifications I believe?), so I didn't open up an issue yet. /cc @Bamieh

Can we get a writer to take a pass at this? I'd expect to see these imperative statements as button labels, not as state change confirmations. I'm more used to seeing something like "Elasticsearch deprecations will be logged" and "Elasticsearch deprecations won't be logged".

@debadair would you mind taking another pass at this? CJ included screenshots in his original comment, but feel free to reach out if you need any additional context.

I think a flyout will give us more real estate to show the user a long list of steps. We can also provide more identifiable information in the header, like the "Critical" badge and whatever else is being surfaced in the table row. We can also surface the "Quick resolve" button in the footer. WDYT?

I originally had a flyout, but Michael suggested using a modal instead. I can't recall now what the reasoning was 😅. @mdefazio thoughts here?

Before I click "Resolve" I'd like to know what the outcome will be. To be honest I don't really know what happened even after clicking the button. A better UX would be modal content that sets my expectations appropriately (e.g. "Your 5 timelion sheets will be converted into dashboards. You will be able to find them in the Dashboards app, with the prefix 'Converted-timelion' in their name.") and success toast content that confirms those expectations have been met (e.g. "5 timelion sheets converted to dashboards. Find them in the Dashboards app. [Link]).

👍 Similar feedback was recently brought up in demo. I opened #98482 on the core side to add support for this.

alisonelizabeth · 2021-04-28T13:51:04Z

Pending copy and design review, I believe I've addressed all feedback up to this point. A few suggestions related to the UX I will explore outside of this PR and address separately:

Consider using EuiTable component instead of a custom list component with EuiAccordion for listing deprecations
Support ability for a user to choose page count (currently hard-coded to 25)
Improvements to the stats panels
- Consider using EuiCard to make entire panel clickable
- Better UX for when there are 0 deprecations
Reconsider use of flyout vs. modal for showing Kibana manual steps
Once [Core deprecations service] Add description field to API action #98482 is implemented, add details to Kibana API action

mdefazio

Minimal scss changes look good.

@dborodyansky will follow up with a separate issue for UX tweaks.

alisonelizabeth · 2021-04-29T19:33:56Z

@elasticmachine merge upstream

kibanamachine · 2021-04-29T21:29:17Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`upgradeAssistant`	72	87	+15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`upgradeAssistant`	119.5KB	146.4KB	+26.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`upgradeAssistant`	30.2KB	29.3KB	-892.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id	before	after	diff
`upgrade-assistant-telemetry`	13	14	+1

History

💚 Build #122966 succeeded 59412ce
💔 Build #122962 failed 52fe1fd
💚 Build #122724 succeeded 138cd07
💚 Build #122722 succeeded 0f227f9
💚 Build #122435 succeeded 0aa953e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dborodyansky

Migrating UX design thread to planning issue.

alisonelizabeth · 2021-04-30T13:03:38Z

I'm going to go ahead and merge this. Will address design and copy changes separately.

debadair

@alisonelizabeth I left some general comments, but have a few more specific ones to add. (In particular, I'd init cap Critical and Warning."

debadair · 2021-05-05T21:37:52Z

...ins/upgrade_assistant/public/application/components/kibana_deprecations/deprecation_item.tsx

+const i18nTexts = {
+  getDeprecationTitle: (domainId: string) => {
+    return i18n.translate('xpack.upgradeAssistant.deprecationGroupItemTitle', {
+      defaultMessage: "'{domainId}' is using a deprecated feature",


Having a collapsible list of non-specific titles isn't very helpful--especially since one plugin might have multiple deprecation entries. This & the "Fix xyz" terminology also makes it sound like you need to fix the plugin itself.

Is there any way to surface what the actual problem is at this point? Something like:

Reporting: The xpack.reporting.roles setting is deprecated.

Also, showing the raw domainId strings isn't very user-friendly--especially for the "xpack" plugins, because xpack doesn't really mean much anymore.

👍 This feedback has come up a few times. The deprecations service currently only supports providing a description, which is quite long in some cases. I've opened #99625 so that a title can also be provided and it won't be hard-coded in UA.

debadair · 2021-05-05T21:38:36Z

...ins/upgrade_assistant/public/application/components/kibana_deprecations/deprecation_item.tsx

+    });
+  },
+  docLinkText: i18n.translate('xpack.upgradeAssistant.deprecationGroupItem.docLinkText', {
+    defaultMessage: 'View documentation',


It feels like any links to more information should be Learn more links within the description of the deprecation.

I think this may have been carried over from the ES deprecations list, where there may be one deprecation type that affects several indices, and therefore we only link to the docs once. @dborodyansky is doing an audit of the ES deprecations page vs. Kibana and making sure both UIs are aligned. I'm going to hold off on making any changes here until then.

debadair · 2021-05-05T22:21:15Z

...ins/upgrade_assistant/public/application/components/kibana_deprecations/deprecation_item.tsx

+  manualFixButtonLabel: i18n.translate(
+    'xpack.upgradeAssistant.deprecationGroupItem.fixButtonLabel',
+    {
+      defaultMessage: 'Show steps to fix',


"Show steps to fix" and "Quick resolve" are an awkward pairing.

Instead of a generic "Quick resolve" label, is it possible to provide an indication of what's going to happen/what you need to do? For example, "Migrate worksheets". If there's a way to do it automatically, the next prompt could list what's going to happen and include the Quick resolve button as CJ suggested.

Unless it's really clear what's going to happen, I think people will be reluctant to choose "Quick resolve".

That's a fair point.

I opened #98482, which will allow the consumer to define an explanation of what the "automatic fix" will do. However, I don't think this would be applicable to the button label, and I'm also not sure it makes sense to add another field for the user to define something like this.

Do you have any other suggestions? Once #96060 is implemented, we will know whether the deprecation is config- or feature-related. I'm not sure if that would help here or not.

Also, in #97159 (review), CJ suggested co-locating the manual steps and "quick resolve" button in the same flyout. In we went in this direction, I think there would only be a single initial entry point. /cc @dborodyansky

debadair · 2021-05-05T22:23:42Z

.../upgrade_assistant/public/application/components/kibana_deprecations/kibana_deprecations.tsx

+    defaultMessage: 'Kibana',
+  }),
+  pageDescription: i18n.translate('xpack.upgradeAssistant.kibanaDeprecations.pageDescription', {
+    defaultMessage: 'Some Kibana issues may require your attention. Resolve them before upgrading.',


Review the issues listed here and make the necessary changes before upgrading.
Critical issues must be resolved before you upgrade.

debadair · 2021-05-05T22:27:10Z

...de_assistant/public/application/components/kibana_deprecations/resolve_deprecation_modal.tsx

+    i18n.translate(
+      'xpack.upgradeAssistant.kibanaDeprecations.resolveConfirmationModal.modalTitle',
+      {
+        defaultMessage: "Resolve '{domainId}'?",


Resolving seems really weird. Maybe Resolve deprecation in ? (I don't really like "resolve deprecation" either, but that's how we talk about instances of using deprecated features.

debadair · 2021-05-05T22:28:01Z

.../plugins/upgrade_assistant/public/application/components/kibana_deprecations/steps_modal.tsx

+const i18nTexts = {
+  getModalTitle: (domainId: string) =>
+    i18n.translate('xpack.upgradeAssistant.kibanaDeprecations.stepsModal.modalTitle', {
+      defaultMessage: "Fix '{domainId}'",


Can this be more specific? Again, you're not fixing the plugin, you're fixing a specific instance of a deprecated feature being used.

Not currently. For now, I could follow the same suggestion in #97159 (comment).

debadair · 2021-05-05T22:31:18Z

.../plugins/upgrade_assistant/public/application/components/kibana_deprecations/steps_modal.tsx

+  modalDescription: i18n.translate(
+    'xpack.upgradeAssistant.kibanaDeprecations.stepsModal.modalDescription',
+    {
+      defaultMessage: 'Follow the steps below to address this deprecation.',


I'd use resolve instead of introducing another word for fix. Again, it would be better if this could be specific, rather than a generic intro. If it has to be generic, "To resolve this deprecation:" or, maybe just omit the intro entirely? It doesn't really add anything.

alisonelizabeth · 2021-05-10T14:16:31Z

@debadair thanks for the copy review! I've addressed some of your feedback in #99632. I few of your comments will require changes to the Kibana deprecations service and I will need to address separately.

alisonelizabeth added 2 commits April 14, 2021 13:10

add support for kibana deprecations

8fe94fb

design fixes

16ba626

alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Upgrade Assistant v7.14.0 labels Apr 14, 2021

alisonelizabeth added 4 commits April 14, 2021 14:22

fix build errors

e68a6a0

update overview tests

98a8c30

add tests for kibana deprecations

a0376ea

Merge branch 'master' of https://github.com/elastic/kibana into ua/ki…

ac3d921

…bana_deprecations

alisonelizabeth added 3 commits April 27, 2021 10:59

Merge branch 'master' of https://github.com/elastic/kibana into ua/ki…

f3c9fe8

…bana_deprecations

address review feedback

0f227f9

remove unnecessary code comment

138cd07

cjcenizal requested review from cjcenizal and removed request for jloleysens April 27, 2021 21:02

cjcenizal approved these changes Apr 27, 2021

View reviewed changes

address review feedback

52fe1fd

alisonelizabeth added 2 commits April 28, 2021 09:52

fix telemetry

5ebb45a

update copy

59412ce

alisonelizabeth mentioned this pull request Apr 28, 2021

[Core deprecations service] Add description field to API action #98482

Closed

mdefazio approved these changes Apr 29, 2021

View reviewed changes

Merge branch 'master' into ua/kibana_deprecations

38c7e61

dborodyansky reviewed Apr 29, 2021

View reviewed changes

alisonelizabeth merged commit 577948b into elastic:master Apr 30, 2021

alisonelizabeth deleted the ua/kibana_deprecations branch April 30, 2021 13:03

alisonelizabeth mentioned this pull request Apr 30, 2021

[7.x] [Upgrade Assistant] Support Kibana deprecations (#97159) #98911

Merged

alisonelizabeth added a commit that referenced this pull request Apr 30, 2021

[Upgrade Assistant] Support Kibana deprecations (#97159) (#98911)

92ead83

debadair reviewed May 5, 2021

View reviewed changes

This was referenced May 10, 2021

[Core deprecations service] Add support for deprecation title #99625

Closed

[Upgrade Assistant] Address copy feedback #99632

Merged

alisonelizabeth mentioned this pull request May 14, 2021

Rename client integration test folders #100119

Merged

tsullivan mentioned this pull request May 20, 2021

[Reporting] Use the deprecations service to advise reporting_user config changes #100427

Merged

3 tasks

cjcenizal mentioned this pull request Sep 14, 2021

[Upgrade Assistant] Explore dedicated links to deprecation issue pages inside overview cards #111041

Closed

[Upgrade Assistant] Support Kibana deprecations #97159

[Upgrade Assistant] Support Kibana deprecations #97159

Conversation

alisonelizabeth commented Apr 14, 2021 • edited Loading

How to review

Screenshots

cjcenizal left a comment

Choose a reason for hiding this comment

Deprecations summary

Empty prompt copy

Markdown support

Deprecation toggle feedback

Steps modal vs flyout

Resolution UX

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bamieh Apr 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjcenizal Apr 28, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alisonelizabeth Apr 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alisonelizabeth commented Apr 28, 2021

alisonelizabeth commented Apr 28, 2021

mdefazio left a comment

Choose a reason for hiding this comment

alisonelizabeth commented Apr 29, 2021

kibanamachine commented Apr 29, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

Saved Objects .kibana field count

History

dborodyansky left a comment • edited Loading

Choose a reason for hiding this comment

alisonelizabeth commented Apr 30, 2021

debadair left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alisonelizabeth commented May 10, 2021

alisonelizabeth commented Apr 14, 2021 •

edited

Loading

Bamieh Apr 28, 2021 •

edited

Loading

cjcenizal Apr 28, 2021 •

edited

Loading

alisonelizabeth Apr 29, 2021 •

edited

Loading

dborodyansky left a comment •

edited

Loading