-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upgrade Assistant] Support Kibana deprecations #97159
Changes from 18 commits
8fe94fb
16ba626
e68a6a0
98a8c30
a0376ea
ac3d921
413deba
373f815
cbc289c
9755153
edbc2a4
480b6cd
68cff12
b6f83b6
7a8291b
9db7acf
67bd309
0aa953e
f3c9fe8
0f227f9
138cd07
52fe1fd
5ebb45a
59412ce
38c7e61
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ | |
|
||
import { IconColor } from '@elastic/eui'; | ||
import { invert } from 'lodash'; | ||
import { DeprecationInfo } from '../../../../common/types'; | ||
import { DeprecationInfo } from '../../../common/types'; | ||
|
||
export const LEVEL_MAP: { [level: string]: number } = { | ||
warning: 0, | ||
|
@@ -24,3 +24,5 @@ export const COLOR_MAP: { [level: string]: IconColor } = { | |
warning: 'default', | ||
critical: 'danger', | ||
}; | ||
|
||
export const DEPRECATIONS_PER_PAGE = 25; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe its worth allowing the user to change this number? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a great point. This was the behavior from the old implementation (for showing ES deprecations). I think I'd prefer to address this in a separate PR, but agree it would be better to not hard code this. |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: this is technically a tab, not a page. Might be more future-proof to generically say "a user viewed the list of Elasticsearch cluster deprecations." Same idea with the index deprecations, below.