-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Don't show 'Upgrade available' for agents in hosted policies #97517
Merged
jfsiii
merged 1 commit into
elastic:master
from
jfsiii:do-not-show-hosted-agents-as-upgradeable
Apr 19, 2021
Merged
[Fleet] Don't show 'Upgrade available' for agents in hosted policies #97517
jfsiii
merged 1 commit into
elastic:master
from
jfsiii:do-not-show-hosted-agents-as-upgradeable
Apr 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsiii
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.13.0
labels
Apr 19, 2021
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
approved these changes
Apr 19, 2021
jfsiii
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Apr 19, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 19, 2021
…#97517) ## Summary Close item 3 on elastic#91906. Don't show icon & "upgrade available" for agents in hosted agent policies ### Local testing I'll try to come back and post the exact commands if anyone wants them, but my rough flow was 1. start ES in 7.13 2. checkout kibana 7.x branch and start 3. create agents in kibana 4. stop kibana & ES 5. start ES in 8.0.0-SNAPSHOT 6. switch to kibana `master` branch & start 7. Navigate to http://localhost:5601/app/fleet#/fleet/agents and observe agents with upgrade available 8. assign agent(s) to a hosted agent policy 9. Observe behavior shown in two screenshots ### Don't show "upgrade available" for hosted agents in list <img width="947" alt="Screen Shot 2021-04-19 at 3 08 12 PM" src="https://user-images.githubusercontent.com/57655/115291869-421c2480-a123-11eb-9dd2-6e450775c16b.png"> ### Don't show agent in list when "Upgrade available" filter is selected <img width="945" alt="Screen Shot 2021-04-19 at 3 08 40 PM" src="https://user-images.githubusercontent.com/57655/115291870-421c2480-a123-11eb-9309-09e3de8902f8.png"> closes elastic#91906
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 19, 2021
…#97542) ## Summary Close item 3 on #91906. Don't show icon & "upgrade available" for agents in hosted agent policies ### Local testing I'll try to come back and post the exact commands if anyone wants them, but my rough flow was 1. start ES in 7.13 2. checkout kibana 7.x branch and start 3. create agents in kibana 4. stop kibana & ES 5. start ES in 8.0.0-SNAPSHOT 6. switch to kibana `master` branch & start 7. Navigate to http://localhost:5601/app/fleet#/fleet/agents and observe agents with upgrade available 8. assign agent(s) to a hosted agent policy 9. Observe behavior shown in two screenshots ### Don't show "upgrade available" for hosted agents in list <img width="947" alt="Screen Shot 2021-04-19 at 3 08 12 PM" src="https://user-images.githubusercontent.com/57655/115291869-421c2480-a123-11eb-9dd2-6e450775c16b.png"> ### Don't show agent in list when "Upgrade available" filter is selected <img width="945" alt="Screen Shot 2021-04-19 at 3 08 40 PM" src="https://user-images.githubusercontent.com/57655/115291870-421c2480-a123-11eb-9309-09e3de8902f8.png"> closes #91906 Co-authored-by: John Schulz <john.schulz@elastic.co>
This was referenced Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close item 3 on #91906. Don't show icon & "upgrade available" for agents in hosted agent policies
Local testing
I'll try to come back and post the exact commands if anyone wants them, but my rough flow was
master
branch & startDon't show "upgrade available" for hosted agents in list
Don't show agent in list when "Upgrade available" filter is selected
closes #91906