Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Don't show 'Upgrade available' for agents in hosted policies #97517

Merged

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Apr 19, 2021

Summary

Close item 3 on #91906. Don't show icon & "upgrade available" for agents in hosted agent policies

Local testing

I'll try to come back and post the exact commands if anyone wants them, but my rough flow was

  1. start ES in 7.13
  2. checkout kibana 7.x branch and start
  3. create agents in kibana
  4. stop kibana & ES
  5. start ES in 8.0.0-SNAPSHOT
  6. switch to kibana master branch & start
  7. Navigate to http://localhost:5601/app/fleet#/fleet/agents and observe agents with upgrade available
  8. assign agent(s) to a hosted agent policy
  9. Observe behavior shown in two screenshots

Don't show "upgrade available" for hosted agents in list

Screen Shot 2021-04-19 at 3 08 12 PM

Don't show agent in list when "Upgrade available" filter is selected

Screen Shot 2021-04-19 at 3 08 40 PM

closes #91906

@jfsiii jfsiii added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 labels Apr 19, 2021
@jfsiii jfsiii self-assigned this Apr 19, 2021
@jfsiii jfsiii requested a review from a team as a code owner April 19, 2021 19:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jfsiii jfsiii added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 19, 2021
@jfsiii jfsiii enabled auto-merge (squash) April 19, 2021 20:18
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 786.1KB 786.2KB +130.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jfsiii

@jfsiii jfsiii merged commit 8db3331 into elastic:master Apr 19, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 19, 2021
…#97517)

## Summary
Close item 3 on elastic#91906. Don't show icon & "upgrade available" for agents in hosted agent policies

### Local testing
I'll try to come back and post the exact commands if anyone wants them, but my rough flow was

1. start ES in 7.13
2. checkout kibana 7.x branch and start
3. create agents in kibana
4. stop kibana & ES
5. start ES in 8.0.0-SNAPSHOT
6. switch to kibana `master` branch & start
7. Navigate to http://localhost:5601/app/fleet#/fleet/agents and observe agents with upgrade available
8. assign agent(s) to a hosted agent policy
9. Observe behavior shown in two screenshots
### Don't show "upgrade available" for hosted agents in list
<img width="947" alt="Screen Shot 2021-04-19 at 3 08 12 PM" src="https://user-images.githubusercontent.com/57655/115291869-421c2480-a123-11eb-9dd2-6e450775c16b.png">

### Don't show agent in list when "Upgrade available" filter is selected
<img width="945" alt="Screen Shot 2021-04-19 at 3 08 40 PM" src="https://user-images.githubusercontent.com/57655/115291870-421c2480-a123-11eb-9309-09e3de8902f8.png">


closes elastic#91906
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 19, 2021
…#97542)

## Summary
Close item 3 on #91906. Don't show icon & "upgrade available" for agents in hosted agent policies

### Local testing
I'll try to come back and post the exact commands if anyone wants them, but my rough flow was

1. start ES in 7.13
2. checkout kibana 7.x branch and start
3. create agents in kibana
4. stop kibana & ES
5. start ES in 8.0.0-SNAPSHOT
6. switch to kibana `master` branch & start
7. Navigate to http://localhost:5601/app/fleet#/fleet/agents and observe agents with upgrade available
8. assign agent(s) to a hosted agent policy
9. Observe behavior shown in two screenshots
### Don't show "upgrade available" for hosted agents in list
<img width="947" alt="Screen Shot 2021-04-19 at 3 08 12 PM" src="https://user-images.githubusercontent.com/57655/115291869-421c2480-a123-11eb-9dd2-6e450775c16b.png">

### Don't show agent in list when "Upgrade available" filter is selected
<img width="945" alt="Screen Shot 2021-04-19 at 3 08 40 PM" src="https://user-images.githubusercontent.com/57655/115291870-421c2480-a123-11eb-9309-09e3de8902f8.png">


closes #91906

Co-authored-by: John Schulz <john.schulz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] UI changes related to hosted agent policies
4 participants