Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version with updatecli #207

Merged

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Feb 6, 2023

Details

In elastic/apm-agent-python#1731 we decided to move the bump opbeans mechanism to the consumer side using updatecli.

Related Issue

Part of https://github.com/elastic/observability-robots/issues/1515
Closes https://github.com/elastic/observability-robots/issues/1554
Depends on elastic/apm-agent-python#1731

@reakaleek reakaleek self-assigned this Feb 6, 2023
@reakaleek reakaleek marked this pull request as ready for review February 6, 2023 10:07
@reakaleek reakaleek requested a review from a team February 6, 2023 10:08
@@ -0,0 +1,27 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@reakaleek reakaleek requested a review from a team February 6, 2023 10:24
Copy link

@amannocci amannocci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: To test locally using act

# Build a custom docker image with gh
cat <<'EOF' > ./Dockerfile.ci
FROM ghcr.io/catthehacker/ubuntu:act-latest
RUN \
  curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | sudo dd of=/usr/share/keyrings/githubcli-archive-keyring.gpg \
  && sudo chmod go+r /usr/share/keyrings/githubcli-archive-keyring.gpg \
  && echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | sudo tee /etc/apt/sources.list.d/github-cli.list > /dev/null \
  && sudo apt update \
  && sudo apt install gh -y
EOF
docker buildx build --platform=linux/amd64 -t github-actions-ubuntu:latest -f Dockerfile.ci .

# Run bump-version workflow
act -s GITHUB_TOKEN=<github_token> -p=false -P ubuntu-latest=docker.io/library/github-actions-ubuntu:latest --container-architecture linux/amd64 -W ./.github/workflows/bump-version.yml

@reakaleek reakaleek merged commit 18d597f into elastic:main Feb 7, 2023
@reakaleek reakaleek deleted the feature/bump-version-with-updatecli branch February 7, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants