Migrate Jenkinsfile 2 GH Actions Workflow #1731

reakaleek · 2023-01-30T14:13:02Z

What does this pull request do?

Migrate Jenkinsfile to GH Actions Workflow.

Release flow

As agreed, the release will be automatically triggered on every push of a tag with the pattern v*.*.*.

Follow-ups

Coverage Report https://github.com/elastic/observability-robots/issues/1546
Opbeans bump https://github.com/elastic/observability-robots/issues/1554
Cleanup Jenkins related files after we verified the release is working in GH Actions https://github.com/elastic/observability-robots/issues/1555

Related issues

Closes https://github.com/elastic/observability-robots/issues/1515

apmmachine · 2023-01-30T14:17:27Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-02-06T08:34:47.385+0000
Duration: 18 min 44 sec

Test stats 🧪

Test	Results
Failed	0
Passed	5086
Skipped	3679
Total	8765

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/test linters : Run the Python linters only.
/test full : Run the full matrix of tests.
/test benchmark : Run the APM Agent Python benchmarks tests.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine · 2023-01-30T14:45:58Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`73/73`)	💚
Files	100.0% (`241/241`)	💚
Classes	100.0% (`241/241`)	💚
Lines	91.887% (`18766/20423`)	👎 -0.034
Conditionals	74.941% (`2880/3843`)	👎 -0.104

reakaleek · 2023-01-31T08:50:24Z

Coverage Report will be handled in a follow-up. See https://github.com/elastic/observability-robots/issues/1546

reakaleek · 2023-02-02T12:30:08Z

.github/workflows/release.yml

@@ -0,0 +1,48 @@
+name: release
+
+on:


As agreed, will be triggered on every push of a tag

reakaleek · 2023-02-02T12:30:35Z

Jenkinsfile

@@ -273,32 +247,6 @@ pipeline {
            }
          }
        }
-        stage('Opbeans') {


As agreed with @v1v, this stage will be moved to the consumer side.

https://github.com/elastic/observability-robots/issues/1554

reakaleek · 2023-02-02T12:45:28Z

Coverage Report will be handled in a follow-up.

reakaleek · 2023-02-02T12:47:51Z

.github/workflows/test.yml

+        uses: elastic/apm-pipeline-library/.github/actions/version-framework@current
+        with:
+          # Use .ci/.jenkins_python_full.yml if it's a scheduled workflow, otherwise use .ci/.jenkins_python.yml
+          versionsFile: .ci/.jenkins_python${{ github.event_name == 'schedule' && '_full' || '' }}.yml


This replaces the nightly test.

reakaleek · 2023-02-02T14:51:26Z

.ci/jobs/apm-agent-python-mbp.yml

@@ -19,7 +19,7 @@
        repo: apm-agent-python
        repo-owner: elastic
        credentials-id: 2a9602aa-ab9f-4e52-baf3-b71ca88469c7-UserAndToken
-        head-filter-regex: '^(main|PR-.*|[5-9]\.x|v[0-9].*)$'


This will make the jenkins jobs only run on the tag event and will be omitted on main and pull requests.

v1v

LGTM, just a couple of minor questions

v1v · 2023-02-02T16:30:50Z

.github/workflows/packages.yml

+  schedule:
+    - cron: '0 2 * * *'


What's the reason for this?

~~In Jenkins there was a nightly job that runs the full matrix. Here it's solved with this: #1731 (comment)~~

Okay.. I just noticed it's the wrong file and a copy pasta error. 😅

.github/workflows/snapshoty.yml

.github/workflows/test.yml

reakaleek · 2023-02-02T17:50:17Z

.github/workflows/snapshoty.yml

+
+jobs:
+  packages:
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}


This way it only runs when the test workflow in main was successul.

…kflow

v1v

LGTM, with just a minor question regarding workflows, calls and the download step

v1v · 2023-02-06T09:08:43Z

.github/workflows/release.yml

+      - uses: actions/download-artifact@v3
+        with:
+          name: packages
+          path: dist


Question regarding this step:

Will this step ensure the package to be downloaded is the one produced in the .github/workflows/package.yml?

Just wondering if two parallel workflows run (one for the merge commit in main and another one for the git tag vx.x.x), won't be any overlap between them?

That's a good question, I had the assumption that if the packages workflow is a sub workflow of release, that the release will the download the artifacts only from the sub workflow. I will try to verify this in a sample repo

Alright, I did some testing on a private playground repo:

Given a workflow with push trigger that uploads some artifacts and given a release workflow with a tag trigger, that tries to download the same artifact name. Then the following error shows:

Downloading the artifact only worked if the workflows are "connected" like we are doing it here.

Thanks for verifying this! 👍

basepi

Looks great!

* Migrate Jenkinsfile to GH Actions * Generic naming * Upload junit test and coverage reports on success or on failure * Better naming * Remove cron from packages workflow * Rename all occurences of WEBFRAMEWORK to FRAMEWORK

* handle case when no span is created in GRPC client interceptor closes #1739 * Migrate Jenkinsfile 2 GH Actions Workflow (#1731) * Migrate Jenkinsfile to GH Actions * Generic naming * Upload junit test and coverage reports on success or on failure * Better naming * Remove cron from packages workflow * Rename all occurences of WEBFRAMEWORK to FRAMEWORK * Add a warning about BaseHTTPMiddleware to Starlette docs (#1735) * Add a warning about BaseHTTPMiddleware to Starlette docs Also switch to using get_client() and make the docs simpler for environment variable configuration. * CHANGELOG * Change `server_url` default to avoid ipv6 ambiguity (#1744) * Change `server_url` default to avoid ipv6 ambiguity * Fix failing test and another minor doc fix * Add service.agent.activation_method to metadata (#1743) * Add activation_method to metadata * Add test * Move activation_method default above start_threads * CHANGELOG * Fix nightly scheduled test (#1747) * Split matrix items into chunks to bypass the 256 limit of matrix items in github actions * cleanup * Add comments * Add update-specs updatcli workflow (#1745) * Add update-specs updatcli workflow * Fix paths * Required Status Check (#1749) * Create single status check that can be set as required * Let windows test runs exit with the correct exit code * Set the exit code * Formatting * fix * More readable jq query * Set status check to success in case it's an only-docs PR (#1753) * Set status check to success in case it's a only-docs PR * Set permissions * fix path patterns * Add comments * Update badge (#1752) * Add dynamic config tag to more supported options (#1750) * Fix sha source (#1754) * update changelog --------- Co-authored-by: Jan Calanog <nejcalanog@gmail.com> Co-authored-by: Colton Myers <colton@basepi.net> Co-authored-by: Jan Calanog <jan.calanog@elastic.co>

Fixes typo. #1731

github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Jan 30, 2023

reakaleek force-pushed the feature/migrate-jenkinsfile-2-gh-actions-workflow branch 3 times, most recently from 6c6e6e9 to 51758b1 Compare February 2, 2023 12:29

reakaleek commented Feb 2, 2023

View reviewed changes

.github/workflows/release.yml

@@ -0,0 +1,48 @@

name: release

on:

Copy link

Member Author

reakaleek Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed, will be triggered on every push of a tag

reakaleek commented Feb 2, 2023

View reviewed changes

Migrate Jenkinsfile to GH Actions

b084342

reakaleek force-pushed the feature/migrate-jenkinsfile-2-gh-actions-workflow branch from e852c6e to b084342 Compare February 2, 2023 14:28

Generic naming

9e75a91

reakaleek force-pushed the feature/migrate-jenkinsfile-2-gh-actions-workflow branch from 4d5d92c to 9e75a91 Compare February 2, 2023 14:41

reakaleek requested review from a team February 2, 2023 14:48

reakaleek marked this pull request as ready for review February 2, 2023 14:48

reakaleek commented Feb 2, 2023

View reviewed changes

v1v reviewed Feb 2, 2023

View reviewed changes

reakaleek commented Feb 2, 2023

View reviewed changes

reakaleek added 3 commits February 2, 2023 18:55

Upload junit test and coverage reports on success or on failure

2cf7336

Better naming

f999a11

Remove cron from packages workflow

e368f55

reakaleek requested a review from v1v February 6, 2023 08:23

reakaleek and others added 2 commits February 6, 2023 09:33

Rename all occurences of WEBFRAMEWORK to FRAMEWORK

ebdb699

Merge branch 'main' into feature/migrate-jenkinsfile-2-gh-actions-wor…

47aedd2

…kflow

v1v approved these changes Feb 6, 2023

View reviewed changes

reakaleek mentioned this pull request Feb 6, 2023

Bump version with updatecli elastic/opbeans-python#207

Merged

basepi approved these changes Feb 6, 2023

View reviewed changes

reakaleek self-assigned this Feb 7, 2023

reakaleek merged commit a54a3ae into elastic:main Feb 7, 2023

reakaleek deleted the feature/migrate-jenkinsfile-2-gh-actions-workflow branch February 7, 2023 07:55

v1v added a commit that referenced this pull request Feb 27, 2023

jjbb: filter by v tags

feade29

Fixes typo. #1731

v1v mentioned this pull request Feb 27, 2023

jjbb: filter by v tags #1762

Merged

reakaleek mentioned this pull request Mar 7, 2023

Cleanup Jenkins 2 GH Actions Migration #1769

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Jenkinsfile 2 GH Actions Workflow #1731

Migrate Jenkinsfile 2 GH Actions Workflow #1731

reakaleek commented Jan 30, 2023 •

edited

Loading

apmmachine commented Jan 30, 2023 •

edited

Loading

Build stats

Test stats 🧪

apmmachine commented Jan 30, 2023 •

edited

Loading

reakaleek commented Jan 31, 2023

reakaleek Feb 2, 2023

reakaleek Feb 2, 2023

reakaleek Feb 2, 2023

reakaleek commented Feb 2, 2023

reakaleek Feb 2, 2023

reakaleek Feb 2, 2023

v1v left a comment

v1v Feb 2, 2023

reakaleek Feb 2, 2023 •

edited

Loading

reakaleek Feb 2, 2023 •

edited

Loading

reakaleek Feb 2, 2023

reakaleek Feb 2, 2023

v1v left a comment

v1v Feb 6, 2023

reakaleek Feb 6, 2023

reakaleek Feb 6, 2023 •

edited

Loading

v1v Feb 6, 2023

basepi left a comment

Migrate Jenkinsfile 2 GH Actions Workflow #1731

Migrate Jenkinsfile 2 GH Actions Workflow #1731

Conversation

reakaleek commented Jan 30, 2023 • edited Loading

What does this pull request do?

Release flow

Follow-ups

Related issues

apmmachine commented Jan 30, 2023 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

apmmachine commented Jan 30, 2023 • edited Loading

🌐 Coverage report

reakaleek commented Jan 31, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reakaleek commented Feb 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

v1v left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reakaleek Feb 2, 2023 • edited Loading

Choose a reason for hiding this comment

reakaleek Feb 2, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

v1v left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reakaleek Feb 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

basepi left a comment

Choose a reason for hiding this comment

reakaleek commented Jan 30, 2023 •

edited

Loading

apmmachine commented Jan 30, 2023 •

edited

Loading

apmmachine commented Jan 30, 2023 •

edited

Loading

reakaleek Feb 2, 2023 •

edited

Loading

reakaleek Feb 2, 2023 •

edited

Loading

reakaleek Feb 6, 2023 •

edited

Loading