-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss: Move to zip instead of tar.gz
for the format of the package.
#474
Comments
We had zip support in the past but it was removed here: #59 @jfsiii might chime in what works better and why on the Kibana side. With the work @mtojek is doing on #472 it will be pretty simple to support both. If we support both, we need to discuss if we should adjust the Example:
|
I'd like to support both/multiple. I'm not sure about the specific API. Some options that come to mind are:
|
@jfsiii If you are thinking of an array, are you thinking of one with objects inside? If we go this path, it would allow us to add "metadata" to each download link potentially if needed so Kibana for example does not have to take the |
As discussed in elastic#474 in the future we might have more then one format to download a package. To be prepared for this, downloads becomes an array.
I opened #512 as a draft to get some initial feedback. |
As discussed in elastic#474 in the future we might have more then one format to download a package. To be prepared for this, downloads becomes an array. In this PR, the existing `download` entry is not removed yet. It will be removed as soon as Kibana switched over the usage.
As discussed in elastic#474 in the future we might have more then one format to download a package. To be prepared for this, downloads becomes an array. In this PR, the existing `download` entry is not removed yet. It will be removed as soon as Kibana switched over the usage.
As discussed in elastic#474 in the future we might have more then one format to download a package. To be prepared for this, downloads becomes an array. In this PR, the existing `download` entry is not removed yet. It will be removed as soon as Kibana switched over the usage.
As discussed in #474 in the future we might have more then one format to download a package. To be prepared for this, downloads becomes an array. In this PR, the existing `download` entry is not removed yet. It will be removed as soon as Kibana switched over the usage.
we should only support one format. We agreed that unless there's big complications, it should be ZIP. It's natively support in MacOS and Windows and Linux users will be able to manage. |
Adding this to b2, we need to do this before we go out of beta. |
I opened a PR to remove the list again as we didn't use it yet: #584 If we move to zip, will need to figure out a non breaking way in b2, but should be doable :-) |
@ruflin pinging since this is targeting 7.10. I don't think it'll be a big deal for Kibana, but LMK when there is a PR/Docker image I can use to test |
@jfsiii Can you forsee any platform / streaming specific challenges around decompression zip vs tar.gz in Kibana? Will ping you as soon as this moves forward. We need to first sort out a separate registry for 7.10 as this will be breaking. |
@ruflin writing down what I said to you on Monday, I think we'll be ok. We used to support both. We currently only deal with it in one place, where we decompress it into a Buffer. I think we can replace |
@skh for awareness with your work for installing a package without the registry. |
On the Kibana/EPM side I'd like to suggest that we support both again, at least for a transitional period until all registries are safely switched over. |
This is a breaking change and first needs changes on the Kibana side. The new registry and the new version of Kibana should be either rolled out in sync or Kibana supports both for a bit. Closes elastic#474
This is a breaking change and first needs changes on the Kibana side. The new registry and the new version of Kibana should be either rolled out in sync or Kibana supports both for a bit. Closes elastic#474
@ruflin @skh I put my first pass at it in as a draft PR elastic/kibana#76197 |
@jfsiii Great, did you manage to test this with the changed registry? |
This is a breaking change and first needs changes on the Kibana side. The new registry and the new version of Kibana should be either rolled out in sync or Kibana supports both for a bit. Closes elastic#474
This is a breaking change and first needs changes on the Kibana side. The new registry and the new version of Kibana should be either rolled out in sync or Kibana supports both for a bit. Closes elastic#474
This is a breaking change and first needs changes on the Kibana side. The new registry and the new version of Kibana should be either rolled out in sync or Kibana supports both for a bit. Closes elastic#474
This is a breaking change and first needs changes on the Kibana side. The new registry and the new version of Kibana should be either rolled out in sync or Kibana supports both for a bit. Closes #474
Currently, the package registry uses the
tar.gz
as the compressed package format for shipping the packages down to Kibana. Sadly this format is not supported directly by Windows. It would be nice if we would move to a zip file format this would allow anyone to download the package on windows unzip it and inspect the content.@ruflin I vaguely remember you mentioning that there were some issues in Kibana that prevent us from moving to ZIP.
The text was updated successfully, but these errors were encountered: