-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship packages as zip instead of tar.gz #628
Conversation
Opening this as ready for review even though CI will be red on the integration tests. The reason is that Kibana does not support zip at the moment. |
Do you think it's feasible to prepare an archiver abstraction and support two modes (zip, tar.gz)? |
@mtojek Definitively possible but what would be the advantage of having the abstraction if we only plan to support one? |
Last time we also planned to support single one :) In the description you've written that we can't push it until Kibana supports the zip format. With an appropriate abstraction we don't need to wait for this. |
I realised, only Kibana can handle both as it is a single entry in the registry output ( As soon as elastic/kibana#76197 is merged I'll trigger CI again to see if it goes green. |
The implementation looks good to me, let's wait for the CI to pass all tests. |
jenkins, test this |
fa20118
to
01c0391
Compare
01c0391
to
17361a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single nit-pick only
This is a breaking change and first needs changes on the Kibana side. The new registry and the new version of Kibana should be either rolled out in sync or Kibana supports both for a bit. Closes elastic#474
17361a9
to
286be87
Compare
This is a breaking change and first needs changes on the Kibana side. The new registry and the new version of Kibana should be either rolled out in sync or Kibana supports both for a bit.
Closes #474