Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] Intel OneAPI MKL #964

Merged
merged 3 commits into from
Feb 14, 2024
Merged

[CMake] Intel OneAPI MKL #964

merged 3 commits into from
Feb 14, 2024

Conversation

RMeli
Copy link
Collaborator

@RMeli RMeli commented Feb 13, 2024

This PR removes the custom FindMKL.cmake module in favor of using the MKLConfig.cmake provided by Intel OneAPI MKL (since version 2021.3).

intel-mkl is now deprecated in Spack (see spack/spack#41488), and the last release is 2020.4.30.

We recently moved to Intel OneAPI MKL in DLA-Future (see eth-cscs/DLA-Future#1073), which broke sirius+dlaf since they both use MKL_FOUND and other equally named variables, but then use sirius::mkl and MKL::MKL, respectively. This leads to

    179      The link interface of target "DLAF::LAPACK" contains:
     180    
     181        MKL::MKL
     182    
     183      but the target was not found.  Possible reasons include:

(Thanks @albestro for the help spotting that sharing MKL_FOUND was the root of the problem.)

@toxa81 toxa81 marked this pull request as ready for review February 13, 2024 19:46
Copy link
Collaborator

@simonpintarelli simonpintarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RMeli , lgtm.

@toxa81 toxa81 merged commit 6fb535f into develop Feb 14, 2024
3 checks passed
@toxa81 toxa81 deleted the intel-oneapi-mkl branch February 14, 2024 22:18
abussy pushed a commit to abussy/SIRIUS that referenced this pull request Jun 11, 2024
This PR removes the custom FindMKL.cmake module in favor of using the MKLConfig.cmake provided by Intel OneAPI MKL (since version 2021.3).

intel-mkl is now deprecated in Spack (see spack/spack#41488), and the last release is 2020.4.30.
abussy pushed a commit to abussy/SIRIUS that referenced this pull request Oct 9, 2024
This PR removes the custom FindMKL.cmake module in favor of using the MKLConfig.cmake provided by Intel OneAPI MKL (since version 2021.3).

intel-mkl is now deprecated in Spack (see spack/spack#41488), and the last release is 2020.4.30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants