Start migrating to Intel oneMKL #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(currently legacy mkl is able to detect correctly also oneMKL)
it would be possible to rely on spack for this, but for the moment we opted for keeping both logic. in the future we might change it.
|
cscs-ci run |
- add legacy option for mkl - make openmp dependent to both mkl and mkl_legacy - export mkl_legacy option in cmake module
albestro
force-pushed
the
alby/migrate_to_oneapi
branch
from
64a1967 to
35287cc
Compare
|
cscs-ci run |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
=======================================
Coverage 94.06% 94.06%
=======================================
Files 148 148
Lines 9199 9199
Branches 1164 1164
=======================================
Hits 8653 8653
Misses 323 323
Partials 223 223 ☔ View full report in Codecov by Sentry. |
msimberg
requested changes
Jan 10, 2024
rasolca
reviewed
Jan 11, 2024
they act as a guard to not end up in the official package
|
cscs-ci run |
rasolca
approved these changes
Jan 12, 2024
2 tasks
older versions are considered not compatible
Closed
msimberg
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #878
Close #626
This PR starts with introducing logic for using Intel OneAPI MKL (or oneMKL), which now provides an official CMake Config file. From discussions with @rasolca, for the moment, we opted for keeping also the "legacy" custom module.
DLAF_WITH_MKLtriggers the new logic using official oneMKL CMake config file;DLAF_WITH_MKL_LEGACYtriggers the "legacy" logic which uses our custom CMake module.note: currently,
DLAF_WITH_MKL_LEGACYseems to work fine also for oneAPI MKL installation.Spack
The spack package has been updated the same way. The logic could be simplified by fully relying on spack (have a look here) and just use the "link-line" logic as any other BLAS/LAPACK library would do. This would require a change, since DLAF_WITH_MKL is used not just for linking purpose but also for implementation details like
mkl_set_num_threads. Anyway, this is not needed now and we might evaluate in the future (e.g. when MKL legacy branch will be dropped).note:
intel-parallel-studiois not supported (to my knowledge it has been deprecated too and merged into intel-oneapi)CI
In the CI nothing has changed yet. It still installs
intel-mklas external package, and then spack uses it. The package should™️ deal correctly with it by usingDLAF_WITH_MKL_LEGACY. Switching tointel-oneapi-mklis outside the objectives of this PR (I will open an issue to track this and decide what to dosee #1074).TODO