Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncated rageshake logs & possibly related UISIs #10951

Closed
dbkr opened this issue Sep 24, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3484
Closed

Truncated rageshake logs & possibly related UISIs #10951

dbkr opened this issue Sep 24, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3484
Labels
T-Defect

Comments

@dbkr
Copy link
Member

dbkr commented Sep 24, 2019

Riot seems to have started truncating rageshake logs at some point, in some cases: symptoms being that the last entry in the rageshake log will be from a day or more ago from when the rageshake was sent. Usually the last line is it logging that it's sending a rageshake which is also absent, so I don't think it's just mismatched clocks.
@dbkr dbkr added the T-Defect label Sep 24, 2019
@dbkr dbkr changed the title Truncated rageshake logs Truncated rageshake logs & possibly related UISIs Sep 25, 2019
@dbkr
Copy link
Member Author

dbkr commented Sep 25, 2019

It looks like this is correlated with the device not being able to decrypt messages in encrypted rooms, and appears to be specific to Firefox. Presumably something something indexeddb.

@dbkr
Copy link
Member Author

dbkr commented Sep 25, 2019

Apparently it is not just firefox

dbkr added a commit to matrix-org/matrix-react-sdk that referenced this issue Sep 26, 2019
@dbkr
Truncate debug logs at the start, not the end
796f574 
We left out later parts if we exceeded the maximum log size, which
was deeply unhelpful since the problem almost certainly happened
just before the user hit the 'submit debug logs' button.

Instead, iterate backwards through the fragments and prepend them,
leaving off the earlier ones if we run over the size.

Also, check we're not going to run over the size before adding
the fragment so we might actually stick to the maximum log size.

May fix element-hq/element-web#10951
@dbkr dbkr mentioned this issue Sep 26, 2019
Merged
@turt2live
Copy link
Member

@dbkr apologies for the late post on this, but is this any different from #5822 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Truncate debug logs at the start, not the end matrix-org/matrix-react-sdk
2 participants
@dbkr @turt2live