This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Truncate debug logs at the start, not the end #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We left out later parts if we exceeded the maximum log size, which was deeply unhelpful since the problem almost certainly happened just before the user hit the 'submit debug logs' button. Instead, iterate backwards through the fragments and prepend them, leaving off the earlier ones if we run over the size. Also, check we're not going to run over the size before adding the fragment so we might actually stick to the maximum log size. May fix element-hq/element-web#10951
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We left out later parts if we exceeded the maximum log size, which
was deeply unhelpful since the problem almost certainly happened
just before the user hit the 'submit debug logs' button.
Instead, iterate backwards through the fragments and prepend them,
leaving off the earlier ones if we run over the size.
Also, check we're not going to run over the size before adding
the fragment so we might actually stick to the maximum log size.
May fix element-hq/element-web#10951