Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New room list can have zero/NaN for badge counts #13757

Closed
turt2live opened this issue May 21, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#4625
Closed

New room list can have zero/NaN for badge counts #13757

turt2live opened this issue May 21, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#4625
Assignees
@turt2live
Labels
A-Room-List T-Defect

Comments

@turt2live
Copy link
Member

No description provided.

@turt2live turt2live self-assigned this May 21, 2020
@turt2live turt2live changed the title New room list can have zero for badge counts New room list can have zero/NaN for badge counts May 21, 2020
@turt2live
Copy link
Member Author

Zero is probably the thing detecting the notification settings wrong. NaN appears after a clear cache, implying it doesn't have badge information at all.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 23, 2020
@turt2live
Calculate badges in the new room list more reliably
a19e27d 
Fixes element-hq/element-web#13757

This uses a different way of calculating the badges by using about 6 less variables, and consolidating the remaining ones down.
@turt2live turt2live mentioned this issue May 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-List T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calculate badges in the new room list more reliably matrix-org/matrix-react-sdk
2 participants
@jryans @turt2live