This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Calculate badges in the new room list more reliably #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#13757 This uses a different way of calculating the badges by using about 6 less variables, and consolidating the remaining ones down.
|
I mean if you ctrl Q it then it won't show up |
|
That feels like something to report to the WebStorm team and not fix in our project tbh. This isn't the only place we put the comments to the right, or even below, the definitions. |
|
Fair enough, its buggy even when above:
shows the first comment for the third member. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#13757
This uses a different way of calculating the badges by using about 6 less variables, and consolidating the remaining ones down.