Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message edit history does not render #18742

Closed
callahad opened this issue Aug 25, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6689
Closed

Message edit history does not render #18742

callahad opened this issue Aug 25, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6689
Assignees
Labels
A-Message-Editing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@callahad
Copy link

callahad commented Aug 25, 2021

Steps to reproduce

  1. Edit a message.
  2. Click on the "(edited)" link in the message.

Screenshot 2021-08-25 at 15 52 39

What happened?

The "Message Edits" modal appears, but it is empty aside from the title.

Screenshot 2021-08-25 at 15 51 54

What did you expect?

To see the message edit history.

Operating system

macOS 11.5

Browser information

Firefox 92 (Beta)

URL for webapp

develop.element.io

Have you submitted a rageshake?

No

@callahad
Copy link
Author

Note that the server does respond correctly to the /_matrix/client/unstable/rooms/!.../relations/$.../m.replace/m.room.message query; all of the history is retrieved, it is just not displayed.

The console does not show any errors.

I am using Element version: 24a076a-react-94449953054a-js-92d822d494cc
Olm version: 3.2.3

@robintown robintown added A-Message-Editing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression labels Aug 25, 2021
@SimonBrandner
Copy link
Contributor

Also broken on staging, assigning release-blocker - we should at least take a look

@Palid
Copy link
Contributor

Palid commented Aug 26, 2021

Seems like it's another regression related to the backdrop-blur and different optimisations. Taking.

Palid pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 26, 2021
Palid pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 26, 2021
Palid pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 26, 2021
Palid pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 26, 2021
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Aug 26, 2021
williamkray added a commit to williamkray/element-web that referenced this issue Aug 31, 2021
* Documentation for sentry config ([\element-hq#18608](element-hq#18608)). Contributed by [novocaine](https://github.com/novocaine).
* [Release]Increase general app performance by optimizing layers ([\element-hq#6672](matrix-org/matrix-react-sdk#6672)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid).
* Add a warning on E2EE rooms if you try to make them public ([\element-hq#5698](matrix-org/matrix-react-sdk#5698)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow pagination of the space hierarchy and use new APIs ([\element-hq#6507](matrix-org/matrix-react-sdk#6507)). Fixes element-hq#18089 and element-hq#18427.
* Improve emoji in composer ([\element-hq#6650](matrix-org/matrix-react-sdk#6650)). Fixes element-hq#18593 and element-hq#18593. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow playback of replied-to voice message ([\element-hq#6629](matrix-org/matrix-react-sdk#6629)). Fixes element-hq#18599 and element-hq#18599. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Format autocomplete suggestions vertically ([\element-hq#6620](matrix-org/matrix-react-sdk#6620)). Fixes element-hq#17574 and element-hq#17574. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remember last `MemberList` search query per-room ([\#6640](matrix-org/matrix-react-sdk#6640)). Fixes element-hq#18613 and element-hq#18613. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Sentry rageshakes ([\element-hq#6597](matrix-org/matrix-react-sdk#6597)). Fixes element-hq#11111 and element-hq#11111. Contributed by [novocaine](https://github.com/novocaine).
* Autocomplete has been updated to match modern accessibility standards. Navigate via up/down arrows rather than Tab. Enter or Tab to confirm a suggestion. This should be familiar to Slack & Discord users. You can now use Tab to navigate around the application and do more without touching your mouse. No more accidentally sending half of people's names because the completion didn't fire on Enter! ([\element-hq#5659](matrix-org/matrix-react-sdk#5659)). Fixes element-hq#4872, element-hq#11071, element-hq#17171, element-hq#15646 element-hq#4872 and element-hq#4872.
* Add new call tile states ([\element-hq#6610](matrix-org/matrix-react-sdk#6610)). Fixes element-hq#18521 and element-hq#18521. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Left align call tiles ([\element-hq#6609](matrix-org/matrix-react-sdk#6609)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make loading encrypted images look snappier ([\element-hq#6590](matrix-org/matrix-react-sdk#6590)). Fixes element-hq#17878 and element-hq#17862. Contributed by [Palid](https://github.com/Palid).
* Offer a way to create a space based on existing community ([\element-hq#6543](matrix-org/matrix-react-sdk#6543)). Fixes element-hq#18092.
* Accessibility improvements in and around Spaces ([\element-hq#6569](matrix-org/matrix-react-sdk#6569)). Fixes element-hq#18094 and element-hq#18094.
* [Release] Fix commit edit history ([\element-hq#6690](matrix-org/matrix-react-sdk#6690)). Fixes element-hq#18742 and element-hq#18742. Contributed by [Palid](https://github.com/Palid).
* Fix images not rendering when sent from other clients. ([\#6661](matrix-org/matrix-react-sdk#6661)). Fixes element-hq#18702 and element-hq#18702.
* Fix autocomplete scrollbar and make the autocomplete a little smaller ([\element-hq#6655](matrix-org/matrix-react-sdk#6655)). Fixes element-hq#18682 and element-hq#18682. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix replies on the bubble layout ([\element-hq#6451](matrix-org/matrix-react-sdk#6451)). Fixes element-hq#18184. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show "Enable encryption in settings" only when the user can do that ([\element-hq#6646](matrix-org/matrix-react-sdk#6646)). Fixes element-hq#18646 and element-hq#18646. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix cross signing setup from settings screen ([\element-hq#6633](matrix-org/matrix-react-sdk#6633)). Fixes element-hq#17761 and element-hq#17761.
* Fix call tiles on the bubble layout ([\element-hq#6647](matrix-org/matrix-react-sdk#6647)). Fixes element-hq#18648 and element-hq#18648. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix error on accessing encrypted media without encryption keys ([\element-hq#6625](matrix-org/matrix-react-sdk#6625)). Contributed by [Palid](https://github.com/Palid).
* Fix jitsi widget sometimes being permanently stuck in the bottom-right corner ([\#6632](matrix-org/matrix-react-sdk#6632)). Fixes element-hq#17226 and element-hq#17226. Contributed by [Palid](https://github.com/Palid).
* Fix FilePanel pagination in E2EE rooms ([\element-hq#6630](matrix-org/matrix-react-sdk#6630)). Fixes element-hq#18415 and element-hq#18415. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile buttons ([\element-hq#6624](matrix-org/matrix-react-sdk#6624)). Fixes element-hq#18565 and element-hq#18565. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix vertical call tile spacing issues ([\element-hq#6621](matrix-org/matrix-react-sdk#6621)). Fixes element-hq#18558 and element-hq#18558. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call tiles ([\element-hq#6618](matrix-org/matrix-react-sdk#6618)). Fixes element-hq#18562 and element-hq#18562. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Avoid access token overflow ([\element-hq#6616](matrix-org/matrix-react-sdk#6616)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Properly handle media errors  ([\element-hq#6615](matrix-org/matrix-react-sdk#6615)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix glare related regressions ([\element-hq#6614](matrix-org/matrix-react-sdk#6614)). Fixes element-hq#18538 and element-hq#18538. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call toasts ([\element-hq#6617](matrix-org/matrix-react-sdk#6617)). Fixes element-hq#18557 and element-hq#18557. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix PiP of held calls ([\element-hq#6611](matrix-org/matrix-react-sdk#6611)). Fixes element-hq#18539 and element-hq#18539. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile behaviour on narrow layouts ([\element-hq#6556](matrix-org/matrix-react-sdk#6556)). Fixes element-hq#18398. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix video call persisting when widget removed ([\element-hq#6608](matrix-org/matrix-react-sdk#6608)). Fixes element-hq#15703 and element-hq#15703.
* Fix toast colors ([\#6606](matrix-org/matrix-react-sdk#6606)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove tiny scrollbar dot from code blocks ([\element-hq#6596](matrix-org/matrix-react-sdk#6596)). Fixes element-hq#18474. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve handling of pills in the composer ([\element-hq#6353](matrix-org/matrix-react-sdk#6353)). Fixes element-hq#10134 element-hq#10896 and element-hq#15037. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
BBaoVanC added a commit to boba-best/element.boba.best that referenced this issue Aug 31, 2021
* Documentation for sentry config ([\element-hq#18608](element-hq#18608)). Contributed by [novocaine](https://github.com/novocaine).
* [Release]Increase general app performance by optimizing layers ([\element-hq#6672](matrix-org/matrix-react-sdk#6672)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid).
* Add a warning on E2EE rooms if you try to make them public ([\element-hq#5698](matrix-org/matrix-react-sdk#5698)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow pagination of the space hierarchy and use new APIs ([\element-hq#6507](matrix-org/matrix-react-sdk#6507)). Fixes element-hq#18089 and element-hq#18427.
* Improve emoji in composer ([\element-hq#6650](matrix-org/matrix-react-sdk#6650)). Fixes element-hq#18593 and element-hq#18593. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow playback of replied-to voice message ([\element-hq#6629](matrix-org/matrix-react-sdk#6629)). Fixes element-hq#18599 and element-hq#18599. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Format autocomplete suggestions vertically ([\element-hq#6620](matrix-org/matrix-react-sdk#6620)). Fixes element-hq#17574 and element-hq#17574. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remember last `MemberList` search query per-room ([\#6640](matrix-org/matrix-react-sdk#6640)). Fixes element-hq#18613 and element-hq#18613. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Sentry rageshakes ([\element-hq#6597](matrix-org/matrix-react-sdk#6597)). Fixes element-hq#11111 and element-hq#11111. Contributed by [novocaine](https://github.com/novocaine).
* Autocomplete has been updated to match modern accessibility standards. Navigate via up/down arrows rather than Tab. Enter or Tab to confirm a suggestion. This should be familiar to Slack & Discord users. You can now use Tab to navigate around the application and do more without touching your mouse. No more accidentally sending half of people's names because the completion didn't fire on Enter! ([\element-hq#5659](matrix-org/matrix-react-sdk#5659)). Fixes element-hq#4872, element-hq#11071, element-hq#17171, element-hq#15646 element-hq#4872 and element-hq#4872.
* Add new call tile states ([\element-hq#6610](matrix-org/matrix-react-sdk#6610)). Fixes element-hq#18521 and element-hq#18521. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Left align call tiles ([\element-hq#6609](matrix-org/matrix-react-sdk#6609)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make loading encrypted images look snappier ([\element-hq#6590](matrix-org/matrix-react-sdk#6590)). Fixes element-hq#17878 and element-hq#17862. Contributed by [Palid](https://github.com/Palid).
* Offer a way to create a space based on existing community ([\element-hq#6543](matrix-org/matrix-react-sdk#6543)). Fixes element-hq#18092.
* Accessibility improvements in and around Spaces ([\element-hq#6569](matrix-org/matrix-react-sdk#6569)). Fixes element-hq#18094 and element-hq#18094.
* [Release] Fix commit edit history ([\element-hq#6690](matrix-org/matrix-react-sdk#6690)). Fixes element-hq#18742 and element-hq#18742. Contributed by [Palid](https://github.com/Palid).
* Fix images not rendering when sent from other clients. ([\#6661](matrix-org/matrix-react-sdk#6661)). Fixes element-hq#18702 and element-hq#18702.
* Fix autocomplete scrollbar and make the autocomplete a little smaller ([\element-hq#6655](matrix-org/matrix-react-sdk#6655)). Fixes element-hq#18682 and element-hq#18682. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix replies on the bubble layout ([\element-hq#6451](matrix-org/matrix-react-sdk#6451)). Fixes element-hq#18184. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show "Enable encryption in settings" only when the user can do that ([\element-hq#6646](matrix-org/matrix-react-sdk#6646)). Fixes element-hq#18646 and element-hq#18646. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix cross signing setup from settings screen ([\element-hq#6633](matrix-org/matrix-react-sdk#6633)). Fixes element-hq#17761 and element-hq#17761.
* Fix call tiles on the bubble layout ([\element-hq#6647](matrix-org/matrix-react-sdk#6647)). Fixes element-hq#18648 and element-hq#18648. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix error on accessing encrypted media without encryption keys ([\element-hq#6625](matrix-org/matrix-react-sdk#6625)). Contributed by [Palid](https://github.com/Palid).
* Fix jitsi widget sometimes being permanently stuck in the bottom-right corner ([\#6632](matrix-org/matrix-react-sdk#6632)). Fixes element-hq#17226 and element-hq#17226. Contributed by [Palid](https://github.com/Palid).
* Fix FilePanel pagination in E2EE rooms ([\element-hq#6630](matrix-org/matrix-react-sdk#6630)). Fixes element-hq#18415 and element-hq#18415. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile buttons ([\element-hq#6624](matrix-org/matrix-react-sdk#6624)). Fixes element-hq#18565 and element-hq#18565. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix vertical call tile spacing issues ([\element-hq#6621](matrix-org/matrix-react-sdk#6621)). Fixes element-hq#18558 and element-hq#18558. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call tiles ([\element-hq#6618](matrix-org/matrix-react-sdk#6618)). Fixes element-hq#18562 and element-hq#18562. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Avoid access token overflow ([\element-hq#6616](matrix-org/matrix-react-sdk#6616)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Properly handle media errors  ([\element-hq#6615](matrix-org/matrix-react-sdk#6615)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix glare related regressions ([\element-hq#6614](matrix-org/matrix-react-sdk#6614)). Fixes element-hq#18538 and element-hq#18538. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call toasts ([\element-hq#6617](matrix-org/matrix-react-sdk#6617)). Fixes element-hq#18557 and element-hq#18557. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix PiP of held calls ([\element-hq#6611](matrix-org/matrix-react-sdk#6611)). Fixes element-hq#18539 and element-hq#18539. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile behaviour on narrow layouts ([\element-hq#6556](matrix-org/matrix-react-sdk#6556)). Fixes element-hq#18398. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix video call persisting when widget removed ([\element-hq#6608](matrix-org/matrix-react-sdk#6608)). Fixes element-hq#15703 and element-hq#15703.
* Fix toast colors ([\#6606](matrix-org/matrix-react-sdk#6606)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove tiny scrollbar dot from code blocks ([\element-hq#6596](matrix-org/matrix-react-sdk#6596)). Fixes element-hq#18474. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve handling of pills in the composer ([\element-hq#6353](matrix-org/matrix-react-sdk#6353)). Fixes element-hq#10134 element-hq#10896 and element-hq#15037. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Message-Editing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants