Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalinks to events list 4 servers, not 3 #7682

Closed
turt2live opened this issue Nov 11, 2018 · 1 comment · Fixed by matrix-org/matrix-react-sdk#2331
Closed

Permalinks to events list 4 servers, not 3 #7682

turt2live opened this issue Nov 11, 2018 · 1 comment · Fixed by matrix-org/matrix-react-sdk#2331
Assignees
@turt2live
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

This isn't the end of the world, however the code should only be returning 3 servers. Probably a lack of unit tests to catch this case.
@lampholder lampholder added T-Defect P2 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 15, 2018
@turt2live turt2live self-assigned this Dec 5, 2018
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Dec 6, 2018
@turt2live
Don't consider ACL'd servers as permalink candidates
f08a54e 
and fix the bug where it was picking 4 servers instead of 3. This was due to `<=` instead of `<` in the `MAX_SERVER_CANDIDATES` loop. Added tests for all the things.

Fixes element-hq/element-web#7752
Fixes element-hq/element-web#7682
@turt2live turt2live mentioned this issue Dec 6, 2018
Merged
@turt2live
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#2331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't consider ACL'd servers as permalink candidates matrix-org/matrix-react-sdk
2 participants
@turt2live @lampholder