This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't consider ACL'd servers as permalink candidates #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and fix the bug where it was picking 4 servers instead of 3. This was due to `<=` instead of `<` in the `MAX_SERVER_CANDIDATES` loop. Added tests for all the things. Fixes element-hq/element-web#7752 Fixes element-hq/element-web#7682
dbkr
reviewed
Dec 7, 2018
|
Probably worth pulling it out to the js-sdk (and improving it) when we figure out how the UI should work for setting/modifying ACLs. I'm not super convinced it is in a state of utility right now. |
This was referenced Dec 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#800
Fixes element-hq/element-web#7752
Fixes element-hq/element-web#7682
Also fixes the bug where it was picking 4 servers instead of 3. This was due to
<=instead of<in theMAX_SERVER_CANDIDATESloop. Added tests for all the things.