Support MSC3757: Restricting who can overwrite a state event #17513

AndrewFerr · 2024-08-01T03:16:18Z

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Code style is correct
(run the linters)

Restricting who can overwrite a state event

Support v9 because that is what the MSC says should be supported. Keep supporting v10 because it is the current default room version. Also support v11 because it is the latest room version.

AndrewFerr · 2024-08-08T15:30:47Z

The new & edited unit tests cover the MSC's auth rules. Since they all pass, this PR is ready for review.

clokep · 2024-08-12T19:11:47Z

Can you expand the title of this PR? Each time I see a notification for it I wonder what MSC3757 is.

hughns

@AndrewFerr as per conversation yesterday, I think the feature will need to be opt-in via configuration rather than enabled by default.

AndrewFerr · 2024-08-13T12:58:40Z

I think the feature will need to be opt-in via configuration rather than enabled by default.

This is already opt-in by virtue of working only in rooms of a compatible version (org.matrix.msc3757.9 / .10 / .11).

synapse/event_auth.py

tests/rest/client/test_power_levels.py

synapse/event_auth.py

Also set errcode to M_BAD_JSON. Do this only for MSC3757 rooms.

sandhose

Looks good overall, this is mainly about code style

synapse/api/room_versions.py

synapse/event_auth.py

tests/rest/client/test_power_levels.py

Support only the current default (10) and latest (11) room versions

sandhose

Very minor nitpicks, otherwise looks good to me!

synapse/event_auth.py

This has been addressed

AndrewFerr · 2024-09-11T14:25:31Z

Also note that this has Complement tests: matrix-org/complement#733

Requires matrix-org/complement#733

AndrewFerr · 2024-09-18T12:14:26Z

(Complement CI is expected to fail until matrix-org/complement#733 is merged.)

to avoid confusion with a server administrator

sandhose · 2024-09-26T13:23:38Z

Changed the base branch to release-v1.116 so that I can do another RC with it included

Support MSC3757

7855b97

Restricting who can overwrite a state event

AndrewFerr requested a review from a team as a code owner August 1, 2024 03:16

Add changelog

6ec215b

fkwp mentioned this pull request Aug 1, 2024

Support MSC3779: "Owned" state events #17332

Closed

3 tasks

AndrewFerr added 4 commits August 7, 2024 15:40

Run power level tests on MSC3757 rooms

6a69213

Check if @-prefixed state key is not a user ID

e481238

Test MSC3757 auth rules

248025d

Support MSC3757 for room versions 9 and 11

a12238d

Support v9 because that is what the MSC says should be supported. Keep supporting v10 because it is the current default room version. Also support v11 because it is the latest room version.

Skip redundant characters for some string searches

663da8d

AndrewFerr changed the title ~~Support MSC3757~~ Support MSC3757: Restricting who can overwrite a state event Aug 13, 2024

hughns previously requested changes Aug 13, 2024

View reviewed changes

hughns mentioned this pull request Aug 13, 2024

MSC3757: Restricting who can overwrite a state event matrix-org/matrix-spec-proposals#3757

Open

erikjohnston reviewed Aug 14, 2024

View reviewed changes

synapse/event_auth.py Outdated Show resolved Hide resolved

tests/rest/client/test_power_levels.py Outdated Show resolved Hide resolved

AndrewFerr added 2 commits August 14, 2024 21:27

Add explicit field to room version for MSC3757

c4cc4d8

Parametrize fewer power level unit tests

5657863

AndrewFerr requested review from hughns and erikjohnston August 15, 2024 02:28

Lint

e9d22ba

richvdh reviewed Aug 15, 2024

View reviewed changes

synapse/event_auth.py Outdated Show resolved Hide resolved

anoadragon453 mentioned this pull request Aug 30, 2024

Push-to-talk in video/voice conferencing element-hq/element-web#5993

Open

AndrewFerr added 3 commits September 3, 2024 23:42

Return 400 for @-prefixed, non-userID state key

228d6b4

Also set errcode to M_BAD_JSON. Do this only for MSC3757 rooms.

Define test event type string once

e175871

Lint

a841921

sandhose requested changes Sep 5, 2024

View reviewed changes

AndrewFerr added 3 commits September 5, 2024 15:43

Refactor state key parsing

772d35a

Split & comment allow conditions

ba2ce94

Drop support for room version 9

77af387

Support only the current default (10) and latest (11) room versions

AndrewFerr added 2 commits September 5, 2024 15:43

Refactor unit tests

6f429b6

Use one expression for commented allow conditions

defeb6e

AndrewFerr requested a review from sandhose September 5, 2024 19:46

sandhose reviewed Sep 9, 2024

View reviewed changes

synapse/event_auth.py Show resolved Hide resolved

synapse/event_auth.py Show resolved Hide resolved

synapse/event_auth.py Outdated Show resolved Hide resolved

Narrow caught error type

426f52b

AndrewFerr requested a review from sandhose September 10, 2024 13:36

Remove license header from new test file

8c203af

sandhose approved these changes Sep 11, 2024

View reviewed changes

Run Complement tests

0d901f7

Requires matrix-org/complement#733

AndrewFerr added 4 commits September 23, 2024 16:36

Make suffix test actually use suffix

b16fa10

Test suffixed key without separator

77fc9d2

Lock non-owned-state tests to non-MSC room version

c0dceaf

Test user ID in middle of state key

e1fa3ef

AndrewFerr mentioned this pull request Sep 24, 2024

Add tests for MSC3757 matrix-org/complement#733

Merged

1 task

AndrewFerr and others added 4 commits September 25, 2024 10:02

Rename admin to "room creator"

7bcd7a0

to avoid confusion with a server administrator

Test state with key of a user ID not in the room

d28c17b

Always check the errcode in failure responses

792b065

Merge branch 'develop' into af/msc3757

89b20d4

sandhose changed the base branch from develop to release-v1.116 September 26, 2024 13:22

sandhose merged commit 302534c into element-hq:release-v1.116 Sep 26, 2024
39 checks passed

AndrewFerr deleted the af/msc3757 branch September 26, 2024 18:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support MSC3757: Restricting who can overwrite a state event #17513

Support MSC3757: Restricting who can overwrite a state event #17513

AndrewFerr commented Aug 1, 2024 •

edited

Loading

AndrewFerr commented Aug 8, 2024

clokep commented Aug 12, 2024

hughns left a comment

AndrewFerr commented Aug 13, 2024

sandhose left a comment

sandhose left a comment

AndrewFerr commented Sep 11, 2024

AndrewFerr commented Sep 18, 2024

sandhose commented Sep 26, 2024

Support MSC3757: Restricting who can overwrite a state event #17513

Support MSC3757: Restricting who can overwrite a state event #17513

Conversation

AndrewFerr commented Aug 1, 2024 • edited Loading

Pull Request Checklist

AndrewFerr commented Aug 8, 2024

clokep commented Aug 12, 2024

hughns left a comment

Choose a reason for hiding this comment

AndrewFerr commented Aug 13, 2024

sandhose left a comment

Choose a reason for hiding this comment

sandhose left a comment

Choose a reason for hiding this comment

AndrewFerr commented Sep 11, 2024

AndrewFerr commented Sep 18, 2024

sandhose commented Sep 26, 2024

AndrewFerr commented Aug 1, 2024 •

edited

Loading