fix: repeatedly fetching posts, improve federation logic #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**NOTE** This is a resubmission of [PR elk-zone#1494](elk-zone#1494), which was inadvertently closed by a force-push - [X] Add Cloudflare Pages to deployment guide - [X] Refactor Netlify deployment guide - [X] Add Getting Started page to the deployment guide that covers topics that are common/shared by multiple deployment types - [X] Add cloudflare_pages.yml workflow file (set to workspace/manual trigger)
…deration logic, improve use of LRU cache
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for elk-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
You have commits from #1882 here :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The post/status caching logic is written in a way that triggers multiple fetch requests for the same post in rapid succession, which becomes a problem when rate-limits come into play as well as when there are network bottlenecks (such as those illustrated here). The issue is further exacerbated when the post is authored by someone that has been blocked by the user (or vice versa), or when the remote host is down.
This PR improves fetching logic for posts by caching error response codes, and using that information to decide whether to retry fetch attempts. This PR also does a better job of handling requests for remote posts that:
status.uriinstead of localstatus.id(erroneously) or as a side effect of preview card rendering logic, and