Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in Matrix chat, this PR corrects memory sizes for the STM32U5 family.
Also, mentioned here:
#301 (comment)
Unfortunately I only have a NUCLEO-U575ZI-Q on me, so I am unable to test for other families.
As for testing, after making the change, I generated the
stm32-metapac
per instructions in theREADME
.Then, I copied
build/*
to a fork here:https://github.com/wagcampbell/stm32-data-generated/tree/wgc/stm32u5-memory-fix
Then I added this change to my local embassy
examples/stm32u5/Cargo.toml
:I'm trying to run some of the stm32 examples for the stm32u5, but embassy-stm32 is failing to compile 😆:
I see this, among other erroneous errors. Which leads me to believe I may have generated this incorrectly.
Thought, I get this PR started, but still trying to get a working test.
Thanks!