-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean Text Search Tasks to MTEB #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Adding Korean would be huge :)
From my side, we can pretty much already merge this and then you can add more whenever you want. But we can also leave the PR open if you prefer!
mteb/abstasks/AbsTaskRetrieval.py
Outdated
@@ -130,4 +139,6 @@ def encode_corpus(self, corpus: List[Dict[str, str]], batch_size: int, **kwargs) | |||
(doc["title"] + self.sep + doc["text"]).strip() if "title" in doc else doc["text"].strip() | |||
for doc in corpus | |||
] | |||
if prefix != '': | |||
sentences = [prefix + sentence for sentence in sentences] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this. This should be done in the encode method of the model. If the model has an encode_corpus
function then it will automatically use that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your suggestion to remove this section. Thanks for pointing this out!
Co-authored-by: Niklas Muennighoff <n.muennighoff@gmail.com>
Thank you for your feedback. I concur with proceeding with the current merge. :) |
Co-authored-by: Niklas Muennighoff <n.muennighoff@gmail.com>
Co-authored-by: Niklas Muennighoff <n.muennighoff@gmail.com>
@taeminlee 현재 [run_mteb_korean.py] 파일을 실행하면 평가 task들에 대해서 아래와 같은 오류가 발생합니다.
|
Maybe it was cuz you weren't installing from source? I released a new MTEB version so if you upgrade to |
This include 3 datasets (6 points) across 1 new task (+2 bonus) for korean. Also added 1 points for reviewers.
* docs: Added missing points for #214 Added 6x2 points for guenthermi for datasets and 1 point to Muennighoff for review I have not accounted for bonus points as I am not sure was what available at the time. * docs: added point for #197 Added 2 points for rasdani and 2 bonus points for the first german retrieval (I believe). Added one point for each of the reviewers * docs: added points for #116 This includes 6 points for 3 datasets to slvnwhrl +2 for first german clustering task also added points for reviews * Added points for #134 cmteb This includes 29 datasets (38 points) and 6x2 bonus points (12 points) for the 6 taskXlanguage which was not previously included. All the points are attributed to @staoxiao, though we can split them if needed. We also added points for review. * docs: Added points for #137 polish This includes points for 12 datasets (24) across 4 tasks (8). These points are given to rafalposwiata and then one point for review * docs: Added points for #27 (spanish) These include 9 datasets (18 points) across 4 news tasks (8) for spanish. Points are given to violenil as the contributor, and one points for reviewers. Points can be split up if needed. * docs: Added points for #224 Added points 2 points for the dataset. I could imagine that I might have missed some bonus points as well. Also added one point for review. * docs: Added points for #210 (korean) This include 3 datasets (6 points) across 1 new task (+2 bonus) for korean. Also added 1 points for reviewers. * Add contributor --------- Co-authored-by: Niklas Muennighoff <n.muennighoff@gmail.com>
Hello MTEB maintainers,
I am currently working on a project that involves implementing an embedding model for Korean text search. Through my work, I realized the need for a benchmark, and that's how I came across MTEB. However, I noticed that MTEB does not currently support tasks specifically for Korean language. To address this gap, I have added tasks for Korean text search.
Limitations
At the moment, the implementation does not support a wide range of tasks like PL-MTEB or C-MTEB.
To-Do
I plan to add various tasks using Korean corpora in the near future. For example, I'm considering the addition of tasks like klue-sts.
I believe this enhancement will significantly benefit researchers and developers working with Korean language text search and analysis. I am looking forward to your feedback and suggestions on this addition.
Thank you for considering my contribution.