Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added points for previous submissions #344

Merged
merged 9 commits into from
Apr 11, 2024
Merged

Conversation

KennethEnevoldsen
Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen commented Apr 11, 2024

Added points for previous submissions

For a description of points for each PR see commit messages below.

Tagging the relevant persons here in case I have missed something (in a few cases I am unaware if the tasks were the first of their kind for the given language, and thus should gain a bonus point).

@guenthermi, @Muennighoff, @rasdani, @PhilipMay, @slvnwhrl, @staoxiao, @NouamaneTazi, @rafalposwiata, @violenil, @hanhainebula, @taeminlee.

I have added all the points to the main contributor, but assuming that some of the PRs have multiple contributors we can split it out.

Added 6x2 points for guenthermi for datasets and 1 point to  Muennighoff for review

I have not accounted for bonus points as I am not sure was what available at the time.
Added 2 points for rasdani and 2 bonus points for the first german retrieval (I believe). Added one point for each of the reviewers
This includes 6 points for 3 datasets to slvnwhrl +2 for first german clustering task also added points for reviews
This includes 29 datasets (38 points) and 6x2 bonus points (12 points) for the 6 taskXlanguage which was not previously included.

All the points are attributed to @staoxiao, though we can split them if needed.

We also added points for review.
This includes points for 12 datasets (24) across 4 tasks (8). These points are given to rafalposwiata and then one point for review
These include 9 datasets (18 points) across 4 news tasks (8) for spanish.

Points are given to violenil as the contributor, and one points for reviewers. Points can be split up if needed.
Added points 2 points for the dataset. I could imagine that I might have missed some bonus points as well. Also added one point for review.
This include 3 datasets (6 points) across 1 new task (+2 bonus) for korean. Also added 1 points for reviewers.
Copy link
Contributor

@Muennighoff Muennighoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I think this is fine - If it's multiple contributors then they can just let us know and we'll split it up I think!
Also if there's a mistake or something, they can just submit a PR to fix it. Most important is to show that we made an effort & care!

@imenelydiaker
Copy link
Contributor

I agree with @Muennighoff, let's merge!

@KennethEnevoldsen KennethEnevoldsen merged commit 9dbf500 into main Apr 11, 2024
5 checks passed
@KennethEnevoldsen KennethEnevoldsen deleted the adding-points branch July 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants