Support for Ember 1.13.x #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`childViews` is not supported in Ember > 1.13. To enable communication between parent and child, child register themselves using `register...` and `remove...` method in nearest parent of appropriate type.
Some behavior of component tests changed in latest versions of Ember: * passing `template` to `this.subject` does not render given template. Must pass `layout` instead * setting targetObject in subject failed in latest Ember Some of the changes could be due to Ember 1.13.x issues that will be fixed in future; setting button `id` currently fails due to issue in Ember.
|
All tests except one pass for build on stable ember version. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of ember-bootstrap uses some private api that was changed with the introduction of Glimmer engine with 1.13.x.
This PR includes:
nearestOfTypefor communication ofchildViewsis no longer supported in Ember