[1.13.0 Regression] Views doesn't use attributeBindings

[marcemira]

Hello, I have been using attributeBindings: ['id'] in order to assign id to my route's view. This way I can "namespace" css by route. This has stopped working since 1.13.0 (same as in components). I understand the reasons here #11141 , but it's not valid for a routes view, since it's not written in templates. Am I not folliwing the "right way" or it's really a regression (please feel free to replace the title if not)? Thanks!

[rwjblue]

Confirmed that attributeBinding for id is not working. Here is a JSBin demo.

[marcemira]

@rwjblue here's a JSBin demo

[mixonic]

I do not suggest using an id binding like this, but it seems like a regression.

[marcemira]

Any progress on this issue?

[nybblr]

Same issue here on Ember 1.13.9: I have a component like such:

export default Ember.Component.extend({
  tagName: 'a',
  href: '#',
  id: 'my-component',
  attributeBindings: ['href', 'id'],
  click: function(event) {
    event.preventDefault();
    console.log("CLICK");
  }
}

Interestingly, the id attributeBinding breaks all event handlers (e.g. click never fires), but removing just id from the attributeBindings makes events work again.

[nybblr]

Ah, I get what's happening here. Just to make sure it wasn't related to the concatenatedProperties bug resolved in 1.13.10, I upgraded. Same problem.

But when you attributeBind to id, it overrides the unique ember256 id that is added, presumably for binding those event handlers.

Is there a workaround for this or more relevant issue?

[rwjblue]

The demo JSBin seems to be working properly on release-1-13 branch: http://emberjs.jsbin.com/tufosiz/edit?js,output.

[rwjblue]

Was fixed in #11889.

[nybblr]

#11889 did fix not being able to bind to id at all, but seems to break any event handlers (e.g. a click handler).

Try adding a "click" handler to your example (e.g. an alert) and notice it doesn't fire when attributeBindings includes id. Drop id and try again (I had to change the CSS styling to target the class instead of ID so I could still see the square) and notice the click handler works now.

[runspired]

it appears you can get around this bug by binding like this

attributeBindings: ['id:id', 'href:href']

[Serabe]

@rwjblue this is still happening in 2.5.0 when the attribute being passed is static. Check in previous twiddle that it works for {{attr-test}} and {{attr-test rows=externalRows}} but not for {{attr-test rows=4}}.

[Serabe]

Seems fixed in 2.12 (Ember-Twiddle). Closing this.

Thank you everyone!