Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

avoid writing jshint ignore in blueprint tests if jshint is not detected #118

Merged
merged 1 commit into from
Oct 25, 2016
Merged

avoid writing jshint ignore in blueprint tests if jshint is not detected #118

merged 1 commit into from
Oct 25, 2016

Conversation

philtobias
Copy link
Contributor

Addresses #117.

This will only output the following line if ember-cli-jshint is detected in the project's add on packages.

/* jshint expr:true */

@@ -1,4 +1,4 @@
/* jshint expr:true */
<% if (jshintExists) { %>/* jshint expr:true */<% } %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the <% } %> part should probably be at the beginning of the next line to make sure that we don't have the unnecessary line break at the start of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not following. Can you show me an example of what you mean? The following will output the unnecessary line break as well.

<% if (jshintExists) { %>/* jshint expr:true */
<% } %>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<% if (jshintExists) { %>/* jshint expr:true */
<% } %>import {
  describe,
  it,
...

this should work afaik

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works. Thanks for clarifying. I've updated the code.

This was referenced Aug 11, 2016
@Turbo87
Copy link
Member

Turbo87 commented Oct 25, 2016

thanks! 👍

@Turbo87 Turbo87 merged commit a784371 into ember-cli:master Oct 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants