-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail in FastBoot when addon uses addon docs + ember-cli-fastboot-testing #417
Comments
👍 |
Any chance we can get a release out? This is blocking some other PRs of mine due to floating dependency tests. |
@scalvert I do not have permissions on npm. @samselikoff what's the normal release process? If you would like to give me permissions, I don't mind doing the release. |
Ya no worries, @rwwagner90. I figured you may not have release. I can also ping @pzuraq, who's on my team at work. |
scalvert
added a commit
to ember-app-scheduler/ember-app-scheduler
that referenced
this issue
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was recently introduced here:
https://github.com/ember-learn/ember-cli-addon-docs/blob/master/addon/initializers/route-anchor-jump.js#L9
In FastBoot, there is no
window.location
, so this line causes tests that are written in an addon that usesember-cli-addon-docs
and has tests thatember-cli-fastboot-testing
to fail.One solution I can think of is to just not run this reopen if using FastBoot, since it's related to interactive behavior.
The text was updated successfully, but these errors were encountered: