Refactor route anchor jump system #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* avoid making reopen inside `initialize` (it should only be done once **ever** not once per application) * avoid destructuring from `location` when it is not defined (e.g. FastBoot contexts) * ensure that the super result is properly returned (previously we would drop any promises returned from afterModel 😱)
|
LGTM! Thanks, Rob. |
RobbieTheWagner
approved these changes
Oct 25, 2019
This was referenced Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialize(it should only be done once ever not once per application)locationwhen it is not defined (e.g. FastBoot contexts)Fixes #417