Merge pull request #3279 from joelalejandro/pr-issue-3271

Deprecation if id is Model in deserializeRecordId
emberjs · Jun 14, 2015 · c4376c0 · c4376c0
2 parents c093d72 + 45662c5
commit c4376c0
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/packages/ember-data/lib/system/store.js b/packages/ember-data/lib/system/store.js
@@ -2157,6 +2157,7 @@ function deserializeRecordId(store, data, key, relationship, id) {
 
   //If record objects were given to push directly, uncommon, not sure whether we should actually support
   if (id instanceof Model) {
+    Ember.deprecate("You tried to push a record '" + relationship.parentType + "'' with id '" + Ember.inspect(id) + "' and passed a DS.Model instance as a value for the relationship '" + key + "'. You should instead pass a numerical or string id to represent the record.");
     data[key] = id._internalModel;
     return;
   }