Deprecation if id is Model in deserializeRecordId #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2058,6 +2058,7 @@ function deserializeRecordId(store, data, key, relationship, id) { | |||
|
|
|||
| //If record objects were given to push directly, uncommon, not sure whether we should actually support | |||
| if (id instanceof Model) { | |||
| Ember.deprecate("Passing a record object to push directly into the store has been deprecated. Pass a number or string as a value to represent the record."); | |||
There was a problem hiding this comment.
Can you make the deprecation message a bit more descriptive to the user. Think about if you were to see it pop up in the console. Something with more context like:
You tried pushing a record 'recordType' with id 'id' and passed a DS.Model as a value for the relationship 'relationshipKey' etc.
There was a problem hiding this comment.
Sure, I'll change it in a bit.
|
thanks! |
|
👍 |
|
@joelalejandro Can you add a test for this please |
|
@igorT sure, I'll get to it. |
igorT
added a commit
that referenced
this pull request
Jun 14, 2015
Deprecation if id is Model in deserializeRecordId
|
We already did it, thanks though! |
|
Great @igorT, was out of town during the weekend ^^' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3271