Ember Add-on now depends on bower instead of using pre-built dist #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ | |||
| module.exports = { | |||
| name: 'ember-data', | |||
| init: function() { | |||
| this.treePaths.vendor = '../dist'; | |||
| this.treePaths.bower = '../dist'; | |||
There was a problem hiding this comment.
Can you add a comment to indicate that we use the bower tree so that consuming applications can override?
There was a problem hiding this comment.
So basically move this up?
| @@ -19,8 +19,8 @@ module.exports = { | |||
| // but still allow consumers to bower install their own version that | |||
| // will override ours. | |||
| this.app.import({ | |||
| development: 'vendor/ember-data/ember-data.js', | |||
| production: 'vendor/ember-data/ember-data.prod.js' | |||
| development: 'bower/ember-data/ember-data.js', | |||
There was a problem hiding this comment.
needs to be app.bowerDirectory + '/ember-data/ember-data.js'
jayphelps
force-pushed
the
patch-2
branch
2 times, most recently
from
9e9d866
to
02ead0c
Compare
jayphelps
changed the title
jayphelps
force-pushed
the
patch-2
branch
4 times, most recently
from
753e673
to
dbcbb4f
Compare
|
@rwjblue This should be GTG. |
| "scripts": { | ||
| "postinstall": "bower install", | ||
| "prepublish": "ember build --output-path=dist/ember-data/ --environment production", |
There was a problem hiding this comment.
Can you add the bower install into the prepublish?
prepublish is ran when running npm install (without a package name argument), and before publishing to npm. Adding prepublish as bower install will still leave the instructions in the README on how to build this project work (basically just git clone && npm install && npm start).
…bower dep instead of including a pre-built version
| "scripts": { | ||
| "postinstall": "bower install", | ||
| "prepublish": "ember build --output-path=dist/ember-data/ --environment production", | ||
| "prepublish": "bower install", |
rwjblue
added a commit
that referenced
this pull request
Sep 8, 2014
Ember Add-on now depends on bower instead of using pre-built dist
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long story why...Ask me or @rwjblue sometime and we'll talk your ear off for an hour......