Prepare for publishing. #2247
Closed
Prepare for publishing. #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move `bower install` into `prepublish`. This prevents consumers of the new published `ember-data` package from having `bower` installed globally. Also, nothing changes as far as setup requirements: running `npm install` in the root of the repo runs the `prepublish` script. * Only publish the specific files that we want (leaves ability in the future to publish other types of things).
| "scripts": { | ||
| "postinstall": "bower install", | ||
| "prepublish": "ember build --output-path=dist/ember-data/ --environment production", | ||
| "prepublish": "bower install && rm -rf dist/ && ember build --output-path=dist/ember-data/ --environment production && rm -rf dist/ember-data/bower_components dist/ember-data/docs", |
There was a problem hiding this comment.
@rwjblue I goofed and forgot an equals sign on that --environment=production. Can you fix?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yup, our options parsing doesn't care if it has an equals or not, both are perfectly valid.
2 tasks
|
Superseded by #2249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bower installintoprepublish. This prevents consumers of the new publishedember-datapackage from havingbowerinstalled globally. Also, nothing changes as far as setup requirements: runningnpm installin the root of the repo runs theprepublishscript.